Skip to content

t27c: declared local type wins over cross-module string name (D-1) - #14103

Open
gHashTag wants to merge 2 commits into
masterfrom
fix/t27c-d1-14102
Open

gHashTag wants to merge 2 commits into
masterfrom
fix/t27c-d1-14102

Conversation

@gHashTag

Copy link
Copy Markdown
Collaborator

Closes #14102

A str name declared in an imported module no longer turns == on a numeric param of the same name into std.mem.eql. Declared param types now win over the global string_names set. Adds regression test imported_string_name_does_not_poison_a_numeric_parameter. FROZEN_HASH updated.

Note: built and tested by CI only; the Mac load rule blocked a local cargo build.

🤖 Generated with Claude Code

A str name imported from another module no longer turns == on a numeric
parameter of the same name into std.mem.eql(u8, ...). Closes #14102

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-11-18 19:25:39 UTC

Summary

Status Count
Total Open PRs 4
PRs with Failing Checks 3
PRs with All Checks Green 1
READY 1
FAILING 3
PENDING 0
NO CHECKS YET 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=f7e7286968ed != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

Closes #14102

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-11-18 19:29:20 UTC

Summary

Status Count
Total Open PRs 4
PRs with Failing Checks 2
PRs with All Checks Green 2
READY 1
FAILING 2
PENDING 0
NO CHECKS YET 0

These columns do not partition: 1 + 2 + 0 + 0 = 3, and there are 4 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=f446e370f9b3 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag

Copy link
Copy Markdown
Collaborator Author

Both new reds are inherited, not caused by this diff. emit-bitexact (76 specs newly do not generate, all parse errors in specs this PR does not touch) fails on every PR since 2026-11-17, including #14101 which is master's head: tracked in #13670. t27b native fails on master's own runs (2026-11-17, 2026-11-18): tracked in #13430. No fix pushed.

@gHashTag

Copy link
Copy Markdown
Collaborator Author

t27b native (macos/linux/ratchet) is inherited: master head de792b0 fails linux + ratchet in the same workflow, macos failed on earlier master runs; tracked in #13430. No fix pushed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

t27c: fix cross-module const array equality codegen (D-1)

1 participant