Repository navigation
course: ring 4 theme spec and host main for lesson 01 - #13681
Merged
Merged
Conversation
- specs/course/lesson_01_theme.t27 (module CourseLesson01Theme) t27c check rc=0, test-report 9/9 pass on VPS (r4-theme task) - specs/course/lesson_01_theme_main.t27 (module CourseLesson01ThemeMain) t27c check rc=0, t27c gen rc=0, zig build rc=0, host exit 0 zig test on generated code 4/4 pass rc=0 7 scenes printed, 14 PPM frames 913515 bytes each t27c test-report blocked on VPS by inherited toolchain defect (type 'u8' does not support array initialization syntax at module- level buffer; same block on master lesson_01_frames_main.t27) vacuous pass count to be settled by CI Refs #13251 Closes #13674 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 57513f5c-7ffe-4a26-bf01-545d1a7b787f) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
course: ring 4 theme spec and host main for lesson 01
Adds two spec files for issue #13674 (ring 4, course v2):
specs/course/lesson_01_theme.t27— moduleCourseLesson01Theme, 224 lines, 9 testsspecs/course/lesson_01_theme_main.t27— moduleCourseLesson01ThemeMain, 163 lines, 4 tests, host binary mainBoundary
specs/course/lesson_01_theme.t27specs/course/lesson_01_theme_main.t27Evidence
t27c check (VPS
/root/t27-m13-final/target/release/t27c)t27c test-report on
lesson_01_theme.t27(VPS taskr4-theme)Vacuous pass count is not available on the VPS:
t27c test-reporton the host main spec is blocked by an inherited VPS toolchain defect (type 'u8' does not support array initialization syntaxat a module-level[0] ** Nbuffer; same block onmaster'slesson_01_frames_main.t27, confirmed with a control run). The official vacuous count will be settled by CI.zig test on generated
l01_theme.zig(VPS taskr4-theme-v5)Host binary run (VPS task
r4-theme-v4b/r4-theme-v5)14 PPM frames written to
target/course/theme/, each 913515 bytes (375×812×3).Frame checksums reproducible across two binary runs (identical
cksumoutput).Weaknesses (FR-008: nothing says a frame looks right)
pixels_changedis 304500 of 304500 for every scene and every theme: flat token fills differ by node kind, so the entire raster changes between themes, but the number does not discriminate scenes from each other. A discriminating delta needsvf_card::vc_renderwith real themed layout, outside course: lesson 1 under a theme swap (ring 4) #13674's scope.meaning_changed 0andrects_changed 0on every scene are correct: layout and meaning never read the theme argument, so FR-002 zeros are a regression guard only.poke. Recorded invf_theme.t27; fix is in the T27F writer's scope.\nin the header string, missing loop increment in host test 2,use t27f::vf_meaning::vf_gap;disambiguation line.Closes #13674
Refs #13251
🤖 Generated with Claude Code
Note
Low Risk
Additive course specs and a diagnostic host binary only; no changes to auth, persistence, or core runtime paths.
Overview
Adds ring 4 theme measurement for lesson 01: two new T27 specs that exercise every
lesson_01_fpga_introscene under light vs dark without changing layout or meaning.specs/course/lesson_01_theme.t27introducesCourseLesson01Themehelpers to count meaning-line diffs, rectangle diffs, per-pixel token-fill changes on a 375×812 raster, and AERT contrast failures on text/button/badge nodes, plus nine tests (theme swap invariants, pixel deltas, and contrast bounds).specs/course/lesson_01_theme_main.t27is the host binary: it paints flat token-fill P6 frames (not styledvc_render), writes two PPMs per scene undertarget/course/theme/, prints per-scene metrics, and includes four frame-format/digest tests.The tooling explicitly treats this as metrics evidence for #13674—pixels can change on every cell while meaning/rects stay at zero; it does not assert frames look correct.
Reviewed by Cursor Bugbot for commit 6ab7869. Bugbot is set up for automated code reviews on this repo. Configure here.