Repository navigation
t27f: badge fill holds its label with equal side gaps (Refs #13677) - #13678
Merged
Merged
Conversation
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: eda09435-a29d-49a2-b545-e8614c429d90) |
Contributor
…t (Refs #13677) Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
gHashTag
force-pushed
the
lane/uikit-badge-pad
branch
from
November 14, 2026 07:04
5d518af to
f919c89
Compare
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 4465ff10-7c8e-409c-831b-4bebf12d1f07) |
Contributor
PR DashboardGenerated at: 2026-11-14 07:06:40 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A badge is painted at least as wide as its label plus the style pad on each side, and the label is centred in it, so the text no longer runs past the fill.
specs/t27f/vf_card.t27:vc_nodesizes a badge withvc_badge_wbefore the fill and centres its label the way a button's is; one test of the width arithmetic.runs/m0/kit/: 12 re-rendered frames (stories 20..24 and 30, both themes),gallery/overview.pngrebuilt,gallery/before_after_badges.png, index, README, T27L record.Stacked on #13676; the diff shrinks to this change once that one is merged.
Measured
runs/m0/kit/rc.txtruns/m0/kit/rc.txtNot done, said plainly
Refs #13677
Refs #13667
Refs #13426
🤖 Generated with Claude Code
Note
Low Risk
Scoped UI renderer change to badge sizing and label centering, with golden-frame updates and arithmetic tests; no auth or data paths touched.
Overview
Badges no longer paint with a layout-only width that can be narrower than the label:
vc_nodenow expands the badge fill withvc_badge_w(label width plus horizontal pad on each side) before drawing, and centers badge labels the same way as buttons.A unit test
a_badge_is_never_narrower_than_its_label_plus_both_padscovers the width math only; there is still no pixel test for ink staying inside the fill.runs/m0/kitwas re-rendered for iteration 3: twelve frames changed (stories 20–24 and 30),gallery/before_after_badges.pngand an updated overview/README/t27l_kit.jsondocument the run.Reviewed by Cursor Bugbot for commit f919c89. Bugbot is set up for automated code reviews on this repo. Configure here.