Repository navigation
policy/t27f: close the two genuine seal debts from the reseal wave (Closes #13584) - #13587
Merged
Merged
Conversation
…he colour argument, vf_card_fit test follows the vf_layout height law (Closes #13584)
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 3257f6c9-fc4b-47dd-b628-abfbeee9f8aa) |
Contributor
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 857fb7d6-8bc7-47a7-9e53-56d83f97a9e6) |
Contributor
PR DashboardGenerated at: 2026-11-10 16:17:59 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
specs/t27f/vf_card_fit.t27: the 375-fit test now follows the vf_layout law (Refs epic(t27f): graph-first UI engine -- object graph to meaning, layout, theme, mood, render, diff (t27b + T27F) #13251) -- a text node is as tall asvf_text_heightat its FINAL width; boxes below the title keep their SIZE and shift y by the title height delta; the card height follows its children. Seals clean (5/5, no --force) under zig 0.16.0.specs/policy/ui_raw_values.t27:count_rawskipped to the first argument after '(' and tested THAT for numeric -- but the first argument is the canvas (c), so it counted nothing. Now it skips to the first comma and tests the colour argument; the tests' expectations (literal counted, named constant not) now hold. The string+concat in two tests replaced with comptime++on literals, the only form gen-zig can emit (Refs epic: self-host t27c -- rewrite the compiler from Rust into t27 #5980). Seals clean, all four backends compile.python3 tools/check_seal_coverage.py: zero[stale]/[tests-fail]/[unsealed].tri seals sync-twins: 499 consistent.Follow-up to #13585 (merged before these fixes landed on its branch).
Closes #13584
Note
Low Risk
Changes are spec/test fixes and seal metadata updates in policy and layout modules, with no runtime auth or production-path changes.
Overview
Closes two forced/stale seals from the reseal wave:
ui_raw_valuesandT27fVfCardFit, and refreshes milestone spec seals.In
specs/policy/ui_raw_values.t27,count_rawnow skips the canvas argument and inspects the first colour argument after((it previously treatedcas numeric and counted nothing). Severalcheck_alltests use comptime++on literals instead of runtime+so gen-zig can emit them.In
specs/t27f/vf_card_fit.t27, the 375-fit test assertsvf_layoutbehaviour withvf_text_heightat final widths: title/label heights, vertical shifts for siblings when the title height changes, and card height derived from children.T27fVfCardFitis resealed 5/5 without--force, withvf_text_measurein the seal closure.milestone_integrity,milestone_link, andmilestone_metricsonly drop redundant inline comments on constants; new seal JSON files record clean test runs for those modules.Reviewed by Cursor Bugbot for commit cc20158. Bugbot is set up for automated code reviews on this repo. Configure here.