Repository navigation
t27mcp: fix duplicate body in chain_metrics -- is_generalizing delegates to is_rsi_signal - #13564
Merged
Merged
Conversation
…tes to is_rsi_signal Both functions shared identical bodies (EL_SIGNAL|EL_CONFIRMED threshold). is_generalizing now calls is_rsi_signal, which has the same semantics. Fixes duplicate-bodies gate on master. Closes #13563 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 90f51613-a2f7-41ed-8e43-5e9ae8c57a65) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the duplicate-bodies CI gate failure introduced when chain_metrics.t27 landed via PR #13557.
is_rsi_signal and is_generalizing had identical bodies (both checking EL_SIGNAL|EL_CONFIRMED). Made is_generalizing delegate to is_rsi_signal — same semantics, no duplicate.
Closes #13563
🤖 Generated with Claude Code
Note
Low Risk
Spec-helper DRY refactor only; semantics unchanged and covered by existing tests in chain_metrics.t27.
Overview
is_generalizinginchain_metrics.t27no longer duplicates theEL_SIGNAL/EL_CONFIRMEDchecks; it now returnsis_rsi_signal(level), preserving the same behavior. A doc line was added noting that generalization uses the same evidence threshold as RSI signal.This addresses the duplicate-bodies CI gate that failed after the two helpers had identical implementations.
Reviewed by Cursor Bugbot for commit 508cd2c. Bugbot is set up for automated code reviews on this repo. Configure here.