Repository navigation
fix(t27os): pty_sys real-file tests use repo-relative paths (no home leak) - #13110
Merged
Merged
Conversation
…leak) The 12 hardcoded /Users/playra/ paths fail the secret-scan home-path gate on master. Replace with the relative target/t27os/test-files/ prefix — the same convention filecmp_main.t27 uses. Test behavior unchanged (1/7 under t27b test: @extern stubs; the real verification runs in the filecmp_main executable stand).
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The pty_sys real-file tests (merged in the stage-2b batch) hardcode 12
/Users/playra/...paths — the secret-scan home-path gate fails on master.Fix
Replace with the relative
target/t27os/test-files/prefix (the same convention filecmp_main.t27 uses).Verification
t27b test pty_sys: unchanged (1/7 — @extern stubs in test mode; real I/O verification runs in the filecmp_main executable stand).