Repository navigation
fix(crons): reuse pick_may_run for fix_may_start so the duplicate-bodies gate reads green (Closes #12999) - #13000
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
fix_may_startinspecs/crons/t27-pareto-improvement-loop.t27now reusespick_may_runfromspecs/crons/t27os-night-loop.t27(use crons::t27os-night-loop::pick_may_run;) instead of carrying a byte-identical copy of its body.Why
The
duplicate-bodiescheck has been red on master's own head since 4cfd2f2 (#12914) added the spec:a body written under fix_may_start is now copied [2] time(s) and was in no ledger. An inherited red hides any new duplicate a PR introduces. The gate's own advice is "Reuse the one that exists"; this does that.How
One
.t27file, 5 lines in, 3 out: theuseline aftermodule, a two-line doc comment, and a one-line body that returnspick_may_run(pr_gate_done, own_red_prs). The three asserts offix_start_waits_for_gate_and_repairsare unchanged. No bless:tools/duplicate_bodies_baseline.txtis untouched because the group was never in it.Verified on the lane
python3 tools/dupe_scan.py:duplicate bodies: 1796 of 22661 in 688 group(s) across 2918 spec(s)andok: no new duplicate body, and none of the known groups grew(master head 21e20c4: 1798 in 689 groups,::error::).t27c check(0.5.2+bc19b54e6, T27 OS shell-cell pane):Typecheck OK (0 errors, 0 warnings).t27c test-report: 5 tests, 5 pass, 0 vacuous;fix_start_waits_for_gate_and_repairs3 runtime asserts.Gates
Expected:
duplicate-bodiesgreen on this head.spec-guards,gate-topologyandDocumented t27c subcommands existare red on master's own head before this PR and are not touched here.Merge: draft until the owner's word; then by hand once the four required checks are green. Auto-merge is unavailable (GH_AGENT_TOKEN expired).
Closes #12999
🤖 Generated with Claude Code