Skip to content

fix(crons): reuse pick_may_run for fix_may_start so the duplicate-bodies gate reads green (Closes #12999) - #13000

Merged
gHashTag merged 1 commit into
masterfrom
claude/dupe-fix-may-start
Oct 31, 2026
Merged

gHashTag merged 1 commit into
masterfrom
claude/dupe-fix-may-start

Conversation

@gHashTag

Copy link
Copy Markdown
Collaborator

What

fix_may_start in specs/crons/t27-pareto-improvement-loop.t27 now reuses pick_may_run from specs/crons/t27os-night-loop.t27 (use crons::t27os-night-loop::pick_may_run;) instead of carrying a byte-identical copy of its body.

Why

The duplicate-bodies check has been red on master's own head since 4cfd2f2 (#12914) added the spec: a body written under fix_may_start is now copied [2] time(s) and was in no ledger. An inherited red hides any new duplicate a PR introduces. The gate's own advice is "Reuse the one that exists"; this does that.

How

One .t27 file, 5 lines in, 3 out: the use line after module, a two-line doc comment, and a one-line body that returns pick_may_run(pr_gate_done, own_red_prs). The three asserts of fix_start_waits_for_gate_and_repairs are unchanged. No bless: tools/duplicate_bodies_baseline.txt is untouched because the group was never in it.

Verified on the lane

  • python3 tools/dupe_scan.py: duplicate bodies: 1796 of 22661 in 688 group(s) across 2918 spec(s) and ok: no new duplicate body, and none of the known groups grew (master head 21e20c4: 1798 in 689 groups, ::error::).
  • t27c check (0.5.2+bc19b54e6, T27 OS shell-cell pane): Typecheck OK (0 errors, 0 warnings).
  • t27c test-report: 5 tests, 5 pass, 0 vacuous; fix_start_waits_for_gate_and_repairs 3 runtime asserts.

Gates

Expected: duplicate-bodies green on this head. spec-guards, gate-topology and Documented t27c subcommands exist are red on master's own head before this PR and are not touched here.

Merge: draft until the owner's word; then by hand once the four required checks are green. Auto-merge is unavailable (GH_AGENT_TOKEN expired).

Closes #12999

🤖 Generated with Claude Code

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

duplicate-bodies red on master: fix_may_start copies pick_may_run

1 participant