Repository navigation
fix(t27os): rename the LIVE MYCELIUM band qy so glass_window seals again (Refs #12972) - #12993
Merged
Merged
Conversation
…ow seals again (Refs #12972) draw_qdash declared two const qy in one scope since #12791 (the band qy = qlg_qy(gy) and the queue row qy = qd_queue_row_y(...)), so the generated Zig failed with a shadowing error and t27c seal refused to save. Only the band constant and its two uses are renamed; the queue row keeps qy. Seal re-saved with a post-12824 t27c: spec_hash changes, tests stay 92/92 pass, 0 vacuous. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Merged
2 tasks
Contributor
PR DashboardGenerated at: 2026-10-31 08:53:14 UTC
Summary
Seal Status
|
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #12972
What
draw_qdashinspecs/t27os/glass_window.t27declared twoconst qyin one scope since #12791: the LIVE MYCELIUM band (qlg_qy(gy), line 10022) and the queue row (qd_queue_row_y(...), line 10137). The generated Zig failed with "local constant 'qy' shadows local constant from outer scope", sot27c seal specs/t27os/glass_window.t27 --saverefused andt27os_T27osGlassWindowstayed in thecoverageFAIL list.Change
qytoband_qy: the declaration and its two uses (cg_move,cg_arc). The queue row keepsqy. Theqyat line 3314 is in another function and is untouched..trinity/seals/t27os_T27osGlassWindow.jsonwith a post-fix(#11182): gen-rust lowers a slice-field capture to a copy + report-only seal resync #12824t27c(built from bc19b54, no build was run on the Mac; onet27c seal --savecommand only).Seal comparison (old to new)
spec_hash:49e6ab00...toa74aa51f...(changed, as it must).queen_live_graph.t27is now listed;keys.t27andqueen_dash.t27hashes refreshed.gen_hash_*refreshed.Not in this PR
fpga_fpga_wasm_board(typecheck-red on master) and the five seals re-saved by chore(seals): re-save five of the six stale seals with a fresh t27c (Refs #12972) #12990 are other lanes.@extern, sotri landrefuses it; this is a plain PR, no label. It waits for a hand merge on the owner's word (auto-merge is off repo-wide).Checks
coverageon this head should no longer namet27os_T27osGlassWindowin its FAIL list.🤖 Generated with Claude Code