Skip to content

ci: the stale-arm executor hardened by its first live run (Refs #12606) - #12850

Merged
gHashTag merged 1 commit into
masterfrom
cron/stale-arm-fix
Oct 27, 2026
Merged

gHashTag merged 1 commit into
masterfrom
cron/stale-arm-fix

Conversation

@gHashTag

Copy link
Copy Markdown
Collaborator

Run 40506042955 (the first dispatch) caught two defects, both fixed:

  • 'stale-repair-once' not found killed the run under set -e: the label was created on the repo, and every decoration step now tolerates absence.
  • update-branch on a genuinely conflicted branch fails every hour: per the DIRTY-repair law a conflict is the AUTHOR-HANDS class -- the executor now comments once (self-guarded by its own comment text, no hourly spam) and moves on; only clean-BEHIND branches get update-branch + re-arm.

The file balances to net 0 (the checkout step and the redundant name line dropped; two command pairs joined). The exceptions entry (#12845) carries the owner's quoted chat approval.

…s go to the author once, decorations tolerate absence (Refs #12606)
@gHashTag
gHashTag enabled auto-merge (squash) October 27, 2026 12:51
@tri-claw

tri-claw Bot commented Oct 27, 2026

Copy link
Copy Markdown

Summary by t27-bees

This workflow repairs stale armed PRs hourly: BEHIND branches get update-branch + auto-merge + a "stale-repair-once" label; DIRTY (conflicted) branches now receive a single "author hands needed" comment (guarded against hourly spam) and are skipped; PRs already labeled "stale-repair-once" get a final comment and the label removed. The checkout step was dropped since the gh CLI needs no workspace.

Worth a look

  • .github/workflows/stale-arm-repair.yml:24 — gh pr edit --add-label stale-repair-once || true runs after a ; separator, so the label is added even if update-branch or merge fails. The original ran the label step on the next line (still sequentially under set -e), so a merge failure would have aborted the run before labeling; now the label may be applied to a PR that didn't actually merge.
  • .github/workflows/stale-arm-repair.yml:16 — The spam guard grep -q "author hands needed" matches that substring in any comment on the PR. A human comment containing that phrase would incorrectly suppress the executor's comment.
  • .github/workflows/stale-arm-repair.yml:19-20 — gh pr edit --remove-label stale-repair-once || true and the comment before it are joined with ;. If the comment fails (e.g., API error), the label is still removed. The original ran them on separate lines, so a comment failure under set -e would have stopped the run before label removal.
  • .github/workflows/stale-arm-repair.yml:10 — The actions/checkout@v4 step was removed. Confirm no later step implicitly relies on the repository being checked out (the gh calls operate via API, so this is likely safe).

Read: 1 files, +9 -9, the whole diff. Head 5373c5f. Model: openai-compatible/nvidia/nemotron-3-ultra-550b-a55b. Commands: @t27-bees review | summary | help | pause | resume. Free for every repository.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-27 12:52:56 UTC

Summary

Status Count
Total Open PRs 7
PRs with Failing Checks 7
PRs with All Checks Green 0
READY 0
FAILING 7
PENDING 0
NO CHECKS YET 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=e75b498e5e79 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit af5c55f into master Oct 27, 2026
27 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant