Skip to content

ci: class D and E of the red-x sweep -- the unparseable queue yml, the branch-filter ceiling, the stale canary (Refs #12708) - #12717

Merged
gHashTag merged 2 commits into
masterfrom
ci/class-d-e-fixes
Oct 27, 2026
Merged

gHashTag merged 2 commits into
masterfrom
ci/class-d-e-fixes

Conversation

@gHashTag

Copy link
Copy Markdown
Collaborator

Refs #12708 (classes D and E of the master red-x sweep).

Class D -- Gate Topology (two defects, one commit)

  1. queue-health-report.yml did not parse. The issue-body strings broke out of the run: | block scalar at column 0 (lines 34-37), so YAML died with ScannerError and GitHub could not load the file its own hourly cron points at. Fix: the body is written through printf ... > /tmp/queue-health-body.md and passed with --body-file -- single logical lines, same output, no multi-line shell strings.
  2. UNCLASSIFIED ROSE 24 -> 26. The queue-health epic's two workflows (queue-health-report, pr-queue-drain) landed without classification rows. Per the checker's own law -- classify and lower the ceiling in the same commit -- this classifies those two plus one old file (agent-runner-docker, a sandbox image build) and lowers MAX_UNCLASSIFIED 24 -> 23.

Measured: python3 scripts/ci/check_pr_branch_filters.py exit 0, '23 file(s) remain unread at a ceiling of 23'; yaml.safe_load passes on the fixed yml.

Class E -- Documented Commands (the dead canary)

The self-check plants dead names and demands the checker refuse to run while any resolves. Its fixture still planted git -- but tri git is REAL since trigit (ADR-002: commit/push/status), so the must-not-exist list contained a living command and the fail-closed refusal fired every run. Fix: git graduates out of the fixture; teleport (absent from all four surfaces, verified) takes the planted slot. Measured: --self-check green with all fixture cases ok, against locally built t27c + tri.

Landing note

Owner-approved-foreign: net-positive hand-written lines in scripts/ci/check_pr_branch_filters.py (classification rows + ceiling per the checker's own law), landed by the standing #5980 procedure (server-side commit + label). Owner delegation on record: 'да все три и сделай сам автономно... сам отправляющий клик по закону твой', gHashTag, 2026-10-26, this session.

…e branch-filter ceiling, the stale canary (Refs #12708)
@gHashTag gHashTag added the owner-approved-foreign Owner-approved exception to the only-t27 rule: hand-written foreign code allowed in this PR label Oct 26, 2026
@gHashTag
gHashTag enabled auto-merge (squash) October 26, 2026 18:35
@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-26 18:35:30 UTC

Summary

Status Count
Total Open PRs 15
PRs with Failing Checks 15
PRs with All Checks Green 0
READY 0
FAILING 15
PENDING 0
NO CHECKS YET 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=67adcf31aff7 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@tri-claw

tri-claw Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Summary by t27-bees

This PR fixes a YAML parsing failure in queue-health-report.yml by moving the issue body to a temp file and using --body-file, classifies three previously unclassified workflow files and lowers the unclassified ceiling from 24 to 23, and replaces git with teleport in the documented-commands self-check fixture because tri git is now a real command.

Worth a look

  • .github/workflows/queue-health-report.yml:32-38 — The printf format string interprets % sequences in $BODY; if jq output ever contains % followed by a format character, the rendered body will be corrupted or printf will error.
  • scripts/ci/check_pr_branch_filters.py:77-80 — agent-runner-docker.yml is classified as "sandbox runner image build; the jobs that run inside it carry their own gates". If this workflow ever gains merge-gating steps (e.g., required status checks), the classification becomes incorrect and the ceiling hides a merge-critical file.
  • scripts/ci/check_pr_branch_filters.py:74-76 — queue-health-report.yml and pr-queue-drain.yml are classified as "reporting only; its own failure gates no merge". If either workflow is later wired as a required check, the classification will be stale and the ceiling will mask it.
  • tools/check_documented_commands_exist.py:257-258 — teleport is now the planted dead command. If tri teleport is ever implemented, the self-check will start failing (by design), but the failure mode is a hard refusal to run rather than a clear test failure, which may confuse contributors.
  • scripts/ci/check_pr_branch_filters.py:67-72 — The ceiling dropped only by 1 (24→23) while three files were classified. The comment says "classify a file and lower this in the same commit"; the net unclassified count went from 26 to 23, so the ceiling matches, but the "lower by one per file" discipline wasn't followed literally.

Read: 3 files, +20 -22, the whole diff. Head 1b41c28. Model: openai-compatible/nvidia/nemotron-3-ultra-550b-a55b. Commands: @t27-bees review | summary | help | pause | resume. Free for every repository.

This was referenced Oct 26, 2026
This was referenced Oct 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-27 09:44:59 UTC

Summary

Status Count
Total Open PRs 12
PRs with Failing Checks 9
PRs with All Checks Green 3
READY 2
FAILING 9
PENDING 0
NO CHECKS YET 0

These columns do not partition: 2 + 9 + 0 + 0 = 11, and there are 12 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=67adcf31aff7 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit d8b905e into master Oct 27, 2026
25 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

owner-approved-foreign Owner-approved exception to the only-t27 rule: hand-written foreign code allowed in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant