Repository navigation
claw: make pr_tools.t27 compile and pass (24/24), reseal (Closes #12493) - #12580
Merged
Merged
Conversation
…loses #12493) #12520 merged specs/claw/pr_tools.t27 while it did not compile; red checks hid the BLOCKED test-report. Fixes: - merge_plan is declared in merge_judge and merge_lane: call it as merge_judge::merge_plan; likewise text::has_prefix, text::str_eq - run_gt takes five arguments, not six - t27c keeps string-typed names (struct fields) in one set for the whole spliced spec, so evidence's `path : str` field turned merge_judge's `path == 9` test helper into a string compare; rename those two test helper parameters to pidx (merge_judge 67/67 still green) Seals saved for ClawPrTools (new) and ClawMergeJudge, hashes checked against the spec files. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
…12493) The spec-guards check lowers specs/claw/merge_judge.t27 and diffs it against the committed C file; the t_file and t_named parameter rename path -> pidx was not carried into the generated file. Seven lines changed, all of them that rename. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Merged
3 tasks
Contributor
PR DashboardGenerated at: 2026-10-26 01:35:36 UTC
Summary
Seal Status
|
This was referenced Oct 26, 2026
This was referenced Oct 26, 2026
Contributor
PR DashboardGenerated at: 2026-10-26 02:26:05 UTC
Summary
Seal Status
|
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
#12520 merged specs/claw/pr_tools.t27 while it did not compile. Its checks were red for inherited reasons, so the BLOCKED test report was hidden. This PR makes the spec compile, pass and sealed.
Fixes
path : str, sopath == 9in merge_judge's t_named test helper was lowered to a string compare and Zig refused it. The two helper parameters are renamed pidx (merge_judge stays 67/67).Evidence
samegroup (t27#12498), nothing from these files.Lesson
Read the test report of a new spec before merging; red checks can hide a compile error.
Closes #12493
🤖 Generated with Claude Code