Repository navigation
analog: sar_comparator_q groups C, D, E asserts, gate passes 38/21/17, seal re-saved (Closes #12230) - #12459
Merged
Conversation
Three tests appended at the end of specs/analog/sar_comparator_q.t27 (114 lines, nothing above them moved), for the 7 low-value survivors of groups C, D and E of the census: - C, sq_fd 307/311/314/315: the one-sided difference at the tie word VDD - SQ_DV is the forward one for both kinds on all three axes, and the top word vsb = VDD reads the backward one (25 asserts). - D, sq_dev 348/351: the body slope is left out where the source sits exactly on its rail word, NMOS and PMOS (6 asserts); the lab shows cb is non-zero there, so these were not equivalent mutants. - E, sq_dev 369: the SQ_M_SWAPQ run is pinned by its fold, its residual and its first output time (5 asserts). tri test of the spec: 15 tests, 15 pass, 0 fail, 0 vacuous of 15. Each of the 7 mutants was also run by hand and turned the new test of its group red (4 runs, the other tests stayed green). The mutation gate was not run on this tree and the seal was not saved. The accepted file drops the 7 pending entries and keeps lines 164 and 388 as "dead but kept" with their reasons (34 entries, none pending); the note is extended with the three tests, the lab values and the hand runs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…-saved, doc records the measured run (Closes #12230) The mutation gate on specs/analog/sar_comparator_q.t27 with the 34-entry accepted file printed "38 not killed (21 survived, 17 hung), 38 accepted; 0 accepted line(s) now killed" and "Gate passed", exit 0 (--jobs 2 --timeout 45, master-built compiler, 20:42:30-21:02:23 +07). The forecast of 38 / 21 / 17 held exactly. A first run was stopped by the kill rule when another session's sweep took the 1-min load to 71.7; it gave no result and is recorded as such. The seal of AnalogSarComparatorQ is re-saved with the master-built compiler after master was merged into the lane (--verify exit 0). The note in docs/analog replaces its forecast and "not done" lines with the measured run. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 25, 2026
Merged
Merged
Contributor
This was referenced Oct 25, 2026
Collaborator
Author
|
Merge basis (hand-merge under the rule of 2026-10-25 16:50, owner veto default from 2026-10-26 12:00 +07):
🤖 Addressed by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12230
Test-gap groups C, D and E of
specs/analog/sar_comparator_q.t27, plus the decision on the four dead-line mutants. Part of the analog v0.1 weak-spot sweep (epic #10486, see the ledger there).What changed
specs/analog/sar_comparator_q.t27: 114 lines appended at the end (nothing above moved or removed), three groups of asserts:sq_fdlines 307/311/314/315: the forward difference at the tie wordVDD - SQ_DVfor both kinds on all three axes, and the backward one atvsb = VDD(25 runtime asserts);sq_devlines 348/351: the body slope is left out when the source sits exactly on its rail word, NMOS 2 and PMOS 7 (6 asserts; the lab shows the body slope is non-zero there, so these were real test gaps);sq_devline 369: theSQ_M_SWAPQrun pinned by its fold, its residual and its first output time (5 asserts).docs/analog/mutation-accepted-sar_comparator_q.txt: the 7 pending entries removed (the new tests kill them), lines 164 (x3) and 388 stay as "dead but kept" with a reason; 34 entries, none pending.docs/analog/mutation-sar_comparator_q-2026-10-25.md: extended, and its forecast and "not done" lines replaced with the measured run below..trinity/seals/analog_AnalogSarComparatorQ.json: re-saved with the master-built compiler after master was merged into the lane (--verifyexit 0,tri seals changedCHECKED).Evidence
tri teston the spec: 15 tests, 15 pass, 0 fail, 0 vacuous passes of 15.tri mutate spec --file specs/analog/sar_comparator_q.t27 --accepted docs/analog/mutation-accepted-sar_comparator_q.txt --jobs 2 --timeout 45, master-built compiler, in a T27 OS pane, 20:42:30-21:02:23 +07): "38 not killed (21 survived, 17 hung), 38 accepted; 0 accepted line(s) now killed", "Gate passed", exit 0. The forecast of 38 / 21 / 17 held exactly. Spec and accepted file are byte-identical to the gated tree.Not done
tri coverage --strictwas not run locally; CI runs it.if (!jac) { return; }) is testable by a directsq_devcall and the test was not added: the issue kept the line as dead, and the accepted entry says so.🤖 Generated with Claude Code