Repository navigation
spec(git): diff.t27 counts files by status with if/else, not a Rust match (Closes #12351) - #12352
Merged
Merged
Conversation
…atch (Closes #12351) #4634 filled count_files_by_status with a Rust match block, which t27 does not have, so specs/git/diff.t27 stopped typechecking. As a result the emit-bitexact gate (tools/check_specs_generate.py) has been red on master and on every PR opened since then. The three arms become an if / else if chain on item.status == Kind::X, the idiom the file's own asserts already use. Both seal files naming the spec were resaved with a t27c built from master commit a6bdfef. t27c typecheck specs/git/diff.t27: Typecheck OK (0 errors, 0 warnings). t27c seal --verify specs/git/diff.t27: all hashes MATCH. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
October 25, 2026 08:29
Contributor
This was referenced Oct 25, 2026
Merged
gHashTag
added a commit
that referenced
this pull request
Oct 25, 2026
This was referenced Oct 25, 2026
gHashTag
added a commit
that referenced
this pull request
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12351
What
emit-bitexact("No spec newly fails to generate") has been red on master since #4634. That PR filledcount_files_by_statusinspecs/git/diff.t27with a Rustmatchblock, but t27 has nomatch, so typecheck refuses the spec and no backend generates it. Every PR opened on master since then inherits the failure, for example #12341.This PR replaces the three
matcharms with anif/else ifchain onitem.status == Kind::X, the same idiom the file's own asserts already use. It also resaves the two seal files that name the spec (GitDiff.jsonandgit_GitDiff.json) with at27cbuilt from master commita6bdfefa5.Checks
t27c typecheck specs/git/diff.t27: Typecheck OK (0 errors, 0 warnings).t27c seal --verify specs/git/diff.t27: all hashes MATCH.count_files_by_status.Not fixed here
t27c test-report specs/git/diff.t27still reports BLOCKED. The spec calls a host function,execute_command, at 8 sites, and nothing declares it. That defect predates this PR, and the generation gate does not depend on it.🤖 Generated with Claude Code