Skip to content

analog: pin the 9 surviving mutants of sar_comparator_psp.t27 (Refs #10486) #12099

Closed

Description

@gHashTag

Boundary

specs/analog/sar_comparator_psp.t27 (tests only, appended after the last test; no function body changes), its seal under .trinity/seals/, a new accepted-mutants file docs/analog/mutation-accepted-sar_comparator_psp.txt and a record docs/analog/mutation-sar_comparator_psp-2026-10-25.md. Part of epic #10486 (weak spots of the analog v0.1 release). Follows #12083 (specs/analog/sar_dff_q.t27, PR #12085) and #12086 (specs/analog/sar_switch_q.t27).

User Scenarios

  • Given master at b9d83f9 and a master-built t27c, when tri mutate spec --file specs/analog/sar_comparator_psp.t27 --jobs 4 --timeout 30 runs in a T27 OS shell cell, then it prints 41 mutants, 26 killed, 9 survived, 5 hung, 1 unviable (measured 2026-10-25, exit 0, checkout clean).
  • Given the 9 survivors (lines 158 x2, 179, 200, 204, 216, 217 x3), when each is classified by reading, then each is a test gap, a dead line or an equivalent mutant.
  • Given an equivalent survivor or a hung mutant, then it is named in the accepted file with the reason it is equivalent or "hung by construction".

Requirements

  • FR-001: the spec must gain tests whose expected values come from a second source (hand-computed arguments or a hand-stepped differential, not read back from the function under test) that go red on every survivor that is not equivalent.
  • FR-002: docs/analog/mutation-accepted-sar_comparator_psp.txt must name only equivalent survivors and hung mutants, each with a note, and must not name a line whose mutant a test now kills.
  • FR-003: the spec must be re-sealed only with the master-built t27c, and tri coverage --strict must keep gaps at 0.

Success Criteria

  • SC-001: tri mutate spec --file specs/analog/sar_comparator_psp.t27 --accepted docs/analog/mutation-accepted-sar_comparator_psp.txt --timeout 30 ends with exit 0.
  • SC-002: the new tests pass on the unmutated spec (tri test specs/analog/sar_comparator_psp.t27: 0 fail, 0 vacuous) and docs/analog/mutation-sar_comparator_psp-2026-10-25.md records the 41-mutant census before and after.

Activity

  1. gHashTag commented on Oct 24, 2026

    @gHashTag
    CollaboratorAuthor

    Tick 14 (analog-night-2026-10-25-14) claims this issue: the mutation lane for sar_comparator_psp, same recipe as #12096, #12097 and #12098 (PRs #12108, #12110, #12114). Lane lane-12099, branch lane/analog-comparator-psp-mutants-12099 off current master. Started 04:58 +07. First step is a census on the unmodified spec in the lane, so the Before is measured and not quoted from this issue. Done comment follows with the numbers.

  2. gHashTag commented on Oct 24, 2026

    @gHashTag
    CollaboratorAuthor

    DONE (tick 14, analog-night-2026-10-25-14): sar_comparator_psp mutation lane is up as PR #12115 (Closes #12099).

    • Before (census on the unmodified spec, 04:58-05:00 +07, exit 0): 41 mutants, 26 killed, 9 survived, 5 hung, 1 unviable.
    • After (gate with --accepted, 05:07-05:09 +07, exit 0, "Gate passed."): 32 killed, 2 survived (both accepted), 6 hung (accepted), 1 unviable (not counted by the gate).
    • Of the 9 survivors: 6 killed, 1 became hung (hi + lo > 1 in the first bisection, once the mirrored pair enters it with lo > 0), 2 accepted as equivalent by arithmetic (lines 179 and 217).
    • 3 tests appended at the end of the spec; tri test: 16 pass, 0 fail, 0 vacuous. Seal re-saved with the master-built t27c. Strict coverage: gaps 0, 130/130.
    • The mirrored pair measured: flip +70064 for widths (36, 35), -70062 for (35, 36); pinned as the model's own words, not ngspice values.
    • Record: docs/analog/mutation-sar_comparator_psp-2026-10-25.md. Classification is by reading the arithmetic, not proved by a tool; which test killed which mutant was not measured.

    The claim for this task is released now.

  3. added a commit that references this issue on Oct 30, 2026
    2a36da6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions