This repository was archived by the owner on Jun 24, 2025. It is now read-only.
i18n support again (part 1) - #264
Merged
Merged
Conversation
Nriver
marked this pull request as ready for review
July 24, 2024 01:52
Nriver
marked this pull request as draft
July 24, 2024 01:59
5 advanced options
eliandoran
force-pushed
the
develop
branch
3 times, most recently
from
August 10, 2024 11:14
eff61af to
4090386
Compare
Contributor
|
@Nriver , I think we should integrate the first batch of translations before we proceed any further. Great work so far, by the way. |
Contributor
|
@Nriver , I did the merge on my side since I was familiar with the changes that I did. |
eliandoran
approved these changes
Aug 11, 2024
eliandoran
left a comment
eliandoran
left a comment
Contributor
There was a problem hiding this comment.
Looks really good so far, we can merge it as soon as the Chinese translations are updated.
eliandoran
force-pushed
the
feature/i18n
branch
from
August 11, 2024 03:57
cece492 to
3a837cf
Compare
Collaborator
Author
|
Ok, just updated the links in the Chinese translation file. |
Nriver
marked this pull request as ready for review
August 12, 2024 01:55
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll continue work on i18n here. As #257 was closed accidently.