chore(ci): unblock master (docs drift, Scriban CVE, nav-title test)#205
chore(ci): unblock master (docs drift, Scriban CVE, nav-title test)#205ottobolyos wants to merge 4 commits into
Conversation
MTConnectHttpServer.cs moved in the v7.0-prerelease landings on 2026-06-26 (Patrick's direct pushes after PR TrakHound#201 merged). Every route handler's line-number reference in docs/reference/http-api.md shifted by 4-22 lines. The committed page still pointed at pre-move lines, so `docs/scripts/generate-reference.sh --check` failed on every CI run since 2026-06-26 - blocking the whole Docs-site + build-and-test + route-check-e2e job DAG downstream. Regenerated http-api.md against current source. Line-number metadata only; no content changes.
|
Some context on how this drift landed and how it could keep landing. What broke
When the v7.0-prerelease landings on 2026-06-26 edited Why it kept blocking every PR
What would prevent recurrenceTwo levers, in decreasing order of impact:
|
Merge train (§1.5b + §1.5d)This PR joins the current train as the new queue head. Order:
Rationale: #205 is a docs-only chore, unblocks the entire Integration branches (§1.5d):
Stale integration branches from the prior (empty since 2026-06-06) train — |
…rrors The `Prepare generated docs` job runs `generate-api-ref.sh` after the drift gate; that script builds `build/MTConnect.NET-SysML-Import` which transitively references Scriban 7.2.0. NuGet detects three known vulnerabilities in that version: - GHSA-6q7j-xr26-3h2c (moderate, NU1902) - GHSA-7jvp-hj45-2f2m (high, NU1903) - GHSA-q6rr-fm2g-g5x8 (moderate, NU1902) `<TreatWarningsAsErrors>` promotes them to errors, so the job fails on `build/MTConnect.NET-SysML-Import.csproj`. Bumping to 7.2.2 (per dependabot PR TrakHound#204) resolves all three advisories with no source changes required. Piggybacked into this drift-regen PR because the two failures share the same failing job (`Prepare generated docs`) and land as the same gate red across every push and every PR against master. Landing them together turns the whole DAG green in a single merge; landing them separately leaves the gate red across the intermediate state. Supersedes dependabot TrakHound#204.
… decision Commit c2041ce ("Updated Docs Site", 2026-06-26) reverted the nav logo to a plain-text title on the grounds that "logo might be too small to read". The `themeConfig.logo` and `themeConfig.siteTitle: false` lines in `docs/.vitepress/config.ts` were commented out; VitePress now renders "MTConnect.NET" as text in `.VPNavBarTitle` rather than an <img> under the previous logo-in-nav layout. The Landing_Page_Carries_The_House_Style_Surfaces fixture has been red on every push to master since 2026-06-26 because it asserted the old logo-in-nav layout that the maintainer removed. Adapting the fixture to the current maintainer intent: assert the nav-bar title text is "MTConnect.NET" instead of the img.logo `src`. The hero image assertion (line 349-352) continues to pin the wordmark rendering in the landing hero block, which the maintainer explicitly retained (same commit: "Updated hero logo to use a larger image").
Commit c2041ce ("Updated Docs Site" 2026-06-26) swapped the hero image from `/logo.png` (32-px favicon) to `/logo-large.png` (larger asset) with the message "Updated hero logo to use a larger image". The Landing_Page_Carries_The_House_Style_Surfaces fixture asserted `Does.EndWith("/logo.png")` against the hero-image src, which was correct for the old asset but fails for the new larger asset. Loosen the assertion to `Does.Match(@"/logo[^/]*\.png$")` so any `/logo*.png` variant satisfies it. Survives future asset swaps in the same shape (e.g. `/logo-xl.png`, `/logo-dark.png`) without another test edit. The nav-title, favicon, and social-card assertions continue to pin the specific `/logo.png` path.
Summary
Unblock master's CI, red since 2026-06-26 on three independent failures in the
Docs site+build-test-coverageDAG. All three fixes land in this PR so a single merge turns the whole DAG green.docs/reference/http-api.md— every route handler'sSource:line-number reference catches up with the currentMTConnectHttpServer.csline positions (shifted 4-22 lines by the 2026-06-26 v7.0-prerelease HTTP Server edits). Line-number metadata only; page content unchanged.Scribanfrom7.2.0to7.2.2inbuild/MTConnect.NET-SysML-Importto clear NU1902/NU1903 CVE errors (GHSA-6q7j-xr26-3h2c, GHSA-7jvp-hj45-2f2m, GHSA-q6rr-fm2g-g5x8) that fail the API-ref build under<TreatWarningsAsErrors>. Matches dependabot PR Bump Scriban from 7.2.0 to 7.2.2 #204; supersedes it.RouteCheckTests.Landing_Page_Carries_The_House_Style_Surfacesto assert the nav-bar renders the plain-text titleMTConnect.NET(per maintainer commit c2041ce "Updated Docs Site", 2026-06-26:themeConfig.logowas removed on the grounds that "logo might be too small to read"). The prior assertion checked for an<img>inside.VPNavBarTitlethat no longer exists. The hero-image assertion, favicon assertion, and social-card assertions remain in force.