Fix exact indexing values for half-window calculations#230
Merged
TimonPost merged 1 commit intoTimonPost:masterfrom Sep 2, 2019
Merged
Fix exact indexing values for half-window calculations#230TimonPost merged 1 commit intoTimonPost:masterfrom
TimonPost merged 1 commit intoTimonPost:masterfrom
Conversation
kstrafe
force-pushed
the
ordered-fail-3
branch
from
99207a7 to
be764d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 97.54% 97.56% +0.01%
==========================================
Files 25 25
Lines 2486 2504 +18
==========================================
+ Hits 2425 2443 +18
Misses 61 61
Continue to review full report at Codecov.
|
kstrafe
force-pushed
the
ordered-fail-3
branch
from
be764d5 to
c6b417b
Compare
The previous patches would erroneously skip the value 32767 and drop the next packet (32768). This patch and test ensures that this doesn't happen.
jstnlef
approved these changes
Sep 1, 2019
TimonPost
approved these changes
Sep 2, 2019
jstnlef
pushed a commit
to jstnlef/laminar
that referenced
this pull request
Oct 12, 2019
The previous patches would erroneously skip the value 32767 and drop the next packet (32768). This patch and test ensures that this doesn't happen.
jstnlef
pushed a commit
that referenced
this pull request
Oct 12, 2019
The previous patches would erroneously skip the value 32767 and drop the next packet (32768). This patch and test ensures that this doesn't happen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous patches would erroneously skip the value 32767 and drop the
next packet (32768). This patch and test ensures that this doesn't
happen.