Repository navigation
Keep live shares in People with access using Bot Social's reply_only - #501
Merged
Merged
Conversation
…h access (Fixes ThinkFlowLab#495) normalizeGrant keeps reply_only (as replyOnly) and side; isTalkThroughGrant uses replyOnly as the only rule when the server sends it (joinedRelationships / roster guess only for older servers); a server-confirmed share is never kept apart as a possible talk-through grant, so ThinkFlowLab#383's one row per person holds.
3 tasks
Collaborator
Author
|
Self-review: PASS
|
Birfy
added a commit
to Birfy/FlyBot
that referenced
this pull request
Oct 20, 2026
…ThinkFlowLab#481/ThinkFlowLab#501/ThinkFlowLab#505) Keep ThinkFlowLab#499 composer-label / data-placeholder docs with ThinkFlowLab#481 phone hold-card targets. Regenerated client bundle patch after merge.
Birfy
added a commit
to Birfy/FlyBot
that referenced
this pull request
Oct 20, 2026
…inkFlowLab#481/ThinkFlowLab#501/ThinkFlowLab#505) Keep ThinkFlowLab#495 reply_only People-with-access docs from main with ThinkFlowLab#496 already-have copy and Remove confirm.
Birfy
added a commit
to Birfy/FlyBot
that referenced
this pull request
Oct 20, 2026
…owLab#481/ThinkFlowLab#501/ThinkFlowLab#505) Regenerated client bundle patch after merge; auto-merged social sources keep ThinkFlowLab#498 friend Bot name formatter with ThinkFlowLab#501/ThinkFlowLab#505.
Birfy
added a commit
to Birfy/FlyBot
that referenced
this pull request
Oct 20, 2026
…ThinkFlowLab#481/ThinkFlowLab#501/ThinkFlowLab#505) Regenerated client bundle patch after merge.
Birfy
added a commit
to Birfy/FlyBot
that referenced
this pull request
Oct 20, 2026
…wLab#481/ThinkFlowLab#501/ThinkFlowLab#505) Regenerated ds-bot patches (0005/0008) after merge.
Birfy
added a commit
to Birfy/FlyBot
that referenced
this pull request
Oct 20, 2026
ThinkFlowLab#481/ThinkFlowLab#501/ThinkFlowLab#505) Regenerated ds-bot patches after merge.
Birfy
added a commit
to Birfy/FlyBot
that referenced
this pull request
Oct 20, 2026
…nkFlowLab#481/ThinkFlowLab#501/ThinkFlowLab#505) Regenerated ds-bot patches after merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #495
What. People with access hid a live share once two friends had joined each other's invite (Bot Social regrants the second invite into the first relationship, so both homes recorded it as "joined" and the #383 guess classified the real share as talk-through). The owner could not see or Revoke it.
plugins/social/src/mcp-client.jsnormalizeGrant: keep Bot Social'sreply_only(asreplyOnly) andside.plugins/social/src/social.jsisTalkThroughGrant: when the server sendsreplyOnly, it is the only rule (true= talk-through,false= always a share). ThejoinedRelationships/ roster guess stays only for servers without the field.accessRowskeeps People with access lists the same friend twice when my already-shared Bot joins that friend's invite (talk-through grant shown as a share) #383's one row per person; a grant the server confirmed as a full share is never kept apart as a "possible talk-through" row.docs/subsystems/social.md; changelog fragmentchangelog.d/495-share-reply-only.fixed.md. No Bot Social change.Test. New plugins/social tests (all fail without the fix): regranted share listed once and revocable on the r1 inviter's home (real
join_inviteflow) and on the joiner's home; a reply-only grant alone is never listed; the #383 case withreply_onlykeeps one row per person and Revoke leaves the talk-through grant;normalizeGrantkeepsreply_only/side. Existing #178/#228/#303/#342/#383 tests pass unchanged.Ran:
ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify(incl. plugin lint) at the tip: pass, 0 failures. Not run: live two-home repro against Bot Social prod, smoke bench.Risk tier: T3 (estimate; the controller sets the label)