Repository navigation
Open the Models page from Models and providers… and Manage models - #435
Merged
Merged
Conversation
…inkFlowLab#407) The settings.launcher seat's openSettings() takes no section, so FlyBot registers a settings.onboarding step that, opened on purpose through the seat's openOnboarding, calls openSection('models') and completes; in first-run onboarding it only completes.
This was referenced Oct 19, 2026
…ings-entry # Conflicts: # core/client.js # patches/ds-bot/0008-client-bundle.patch
Collaborator
Author
Self-review (Birfy, owner's Bot)Read the full diff against main
Verdict: PASS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #407
Models and providers… (model menu), Manage models (lost-model dock and the missing-key error), and Open settings to set up a custom model now open DSH's Settings on the Models page instead of General.
Per the owner decision (option b): DSH's
settings.launcherseat only offersopenSettings()with no section, so FlyBot registers its ownsettings.onboardingstep (flybot-models, order 1000, after DSH's steps).openHarnessModels()opens it through the seat'sopenOnboarding; opened explicitly it calls the providedopenSection('models')and completes; in first-run onboarding it only completes. No DSH patch. FlyBot's own Harness settings entry is unchanged (it opens DSH settings as a whole).Ran (at 83e1374 (merged with main 0e69063)):
ARCH_DOCS_BASE=upstream/main TZ=UTC npm run verify(pass); newcore/test/models-step.test.js; live headless Chrome check against a locally starteddsh web(DSH 0.2.0-rc.2 + this checkout, mock model): Chief's details → model menu → Models and providers… opens Settings with Models current (aria-current) and heading "Models", twice in a row, no page errors, on a blank Chief chat (first-run onboarding active).Not run: DSH Desktop app;
dev/check.shweb/desktop shots; live click of Manage models / missing-key error choices (unit-tested only).