Repository navigation
Allow self-PASS, no PASS for T0/T1, add awaiting-approval and self-test labels - #415
Conversation
…licts Owner decisions of 2026-10-19: - A PR opened by the owner's Bot/agent (Birfy) may be PASSed by the owner's own reviewer Bot/agent (review-policy.json `selfReview`); T2/T3 still need the maintainer's approval, green CI, the merge queue; a new commit voids a PASS. - T0/T1 merge through the queue on green CI with no PASS and no approval. - agent-ready is set by a maintainer or the maintenance routine (runs as Birfy). The admin-login sentence now forbids admin-merge and gate bypass instead. - labels.json gains awaiting-approval and self-test. - A Docs-not-needed: trailer goes in a branch commit too (Codex finding on ThinkFlowLab#414). Docs-not-needed: policy and docs only; no subsystem-owned path changed.
Birfy
added
documentation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 879e43320c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| AGENTS.md step 6 is the rule it serves. A PASS is required for **T2 and T3** (together with the maintainer's | ||
| approval); **T0 and T1 need no PASS** and merge on green CI. This report is the evidence of a PASS; it never merges anything. |
There was a problem hiding this comment.
When a T2/T3 PR has maintainer approval but no PASS at its tip, this new rule says PASS is mandatory, but lines 162–168 in the same section still say that a PR without PASS can merge on maintainer approval. The live-rules table also says no review is required by branch protection, so the stale sentence describes an actionable bypass for the highest-risk PRs rather than merely dead prose; reword it to state that Phase 1 lacks enforcement but merging that way is forbidden.
AGENTS.md reference: AGENTS.md:L95-L95
Useful? React with 👍 / 👎.
| # Verifier PASS (`Tip SHA:` + `Verdict: PASS`, by a login in .github/agent/review-policy.json), and | ||
| # why not when it does not. It is NOT a required check: continue-on-error, never labels, comments, | ||
| # approves or merges, and it must stay out of branch protection and out of `tests-ok`'s needs. |
There was a problem hiding this comment.
When a T0/T1 PR has green tests-ok but no PASS, lines 7–8 still tell readers that the standing delegation applies only “when a tip has a PASS.” The changed policy makes PASS unnecessary for these tiers, so this stale operational comment can leave an otherwise eligible low-risk PR waiting for review; update the header to say this report is consumed only for T2/T3.
AGENTS.md reference: AGENTS.md:L94-L94
Useful? React with 👍 / 👎.
…ew (ThinkFlowLab#426) Owner decision 2026-10-19 15:31 (Asia/Shanghai): stop using Codex for PR review. The owner's own reviewer Bot, acting as `Birfy`, reviews and PASSes (self-PASS already allowed by ThinkFlowLab#415, `selfReview: ["Birfy"]`). How Codex was triggered: not by anything in this repo. No workflow, script, routine, label or `@codex` comment requests it (rg of `.github/`, skills, scripts, docs; `gh api repos/ThinkFlowLab/FlyBot/hooks` is empty). The reviews on ThinkFlowLab#402/ThinkFlowLab#414/ThinkFlowLab#415/ThinkFlowLab#416 come from the `chatgpt-codex-connector` GitHub App with trigger "PR opened", i.e. Codex's automatic code review enabled for this repo in ChatGPT Codex settings. That switch is outside the repo and is turned off there by the owner. This PR (wording only, no gate change): - AGENTS.md, CONTRIBUTING.md, docs/autonomous-dev.md, LESSONS.md: the reviewer is the owner's Bot (self-review); nothing requests or waits for Codex. - review-pr skill: drop the OpenCode↔Codex agreement requirement and Verifier line; reviewer's own evidence at the tip decides. - review-gate.test.mjs: neutral fixture login `reviewer-agent` instead of `codex-agent`, drop the unused agreement line (the gate never parsed it). Unchanged: `.github/agent/review-policy.json` (reviewers `hsliuustc0106`, `Birfy`; selfReview `Birfy`; Codex was not listed), CI, risk tiers, T2/T3 maintainer approval. Tip SHA: aa57d50 Ran: - ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify (Node 24.21.0) → pass - node --test .github/scripts/*.test.mjs → pass (88/88) Not run: - smoke / Desktop / live-e2e with a real model — no runtime code changed T3 (touches AGENTS.md and .github/**): needs the maintainer's approval; not merged by the agent.
Follow-up to #414 (already merged at 11:43 Asia/Shanghai, so its branch can no longer carry more commits). Applies the owner's decisions of 2026-10-19 and fixes the doc/config conflicts left by #414. Docs, gate rule and labels in one PR.
Owner decisions applied
Birfy) may be PASSed by the owner's own reviewer Bot/agent. No independent reviewer is required. A new commit still voids a PASS; CI green, the merge queue and "never admin-merge / bypass" stay.review-gateis report-only. Only the docs said so.)agent-readyis set by a maintainer or by the maintenance routine after triage (it runs asBirfy). The "never use a maintainer's admin login" rule now forbids admin-merge and gate bypass instead.Changes
.github/agent/review-policy.json: newselfReview: ["Birfy"](must also be inreviewers); note updated..github/scripts/review-gate.mjs: the author's own report is excluded unless the author is inselfReview. All other rules unchanged (listed reviewer,Tip SHA= head,Ran:andNot run:, newest report wins). Tests: self-PASS counts, other authors still excluded, selfReview does not unlock an unlisted login, stale tip / missing evidence / later FAIL still fail, policy consistency..github/labels.json: addawaiting-approvalandself-test(also created in the repo);agent-readydescription matches the new rule.sync-labels.test.mjschecks the new names.agent-working/agent-pralready existed.AGENTS.md: Pipeline step 6, label line, Gates;Docs-not-needed:goes in a branch commit as well as the body (Codex finding on Document the agent operating model in AGENTS.md #414).docs/autonomous-dev.md: who setsagent-ready, credentials / admin wording, per-tier rule table, self-review in "The reviewed tip", phases..github/agent/risk-rules.json: tiermeaningstrings only (no paths or limits)..github/workflows/review-gate.yml: comment only..github/ISSUE_TEMPLATE/agent-task.yml: wording.docs/code-standards.md,CONTRIBUTING.md,.claude/skills/{review-pr,fix-issue}/SKILL.md: dropped the "author never counts" / "OpenCode and Codex both PASS" wording so nothing conflicts.Tier: T3 (
.github/**,AGENTS.md,CONTRIBUTING.md,docs/code-standards.md,docs/autonomous-dev.md). Needs the maintainer's approval at the head. Not auto-merged.Ran at the tip:
ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify(Node 24): passes (arch-docs OK, .github script tests 255/255 incl. review-gate and sync-labels).node .github/scripts/changelog.mjs checkpasses.Not run: smoke test, pack check (no runtime code changed).
Docs-not-needed: policy and docs only; no subsystem-owned path changed.