[Birfy]

Part of #371 (also touches Birfy/bot-social#13's symptom; the Bot Social regex fix is Birfy/bot-social#14).

Problem

A Bot Social hold on a local Bot's outgoing message was shown only in the chat of the friend's Bot it is addressed to. When that chat is hidden, gone, home-level or absent, nobody could see or decide it, and the sender's chat looked as if it had sent.

Change

• approvalView keeps the Bot Social identity that wrote the hold (botId) and the hold's reasons (holdReasons: only DLP category names, e.g. commitment, pii.phone; never server text). pendingApprovals maps the identity to the local Bot (fromId).
• approvalsForOpenChat: the sender Bot's chat shows the card unless a listed friend chat exists (listedFriendChat: in the roster, not hidden/gone/home-level). A listed friend chat still shows it alone (Approvals: stale 'waiting for the owner' line in Face-to-face rooms; one place per approval; pointer vs open chat #278).
• The card gets a second line, Held for your approval: contains commitment language (en / 中文 via the host translator; the slot now passes t to flybot.session.dock). The held text stays on the card; the bubble only says it waits (earlier decision).
• The sender Bot's sidebar row takes the wait dot: the chatApprovals provider answers for local Bots (fromId), and channel.js no longer limits pendingCount to remote chats.

Decision to check

I did not post a "held" message into the sender's chat: no host API does it for a local Bot, and text written there is read by the Bot's model. The card in that chat carries the note instead. Say if you want a real chat bubble (needs a host API).

Tests

Fail without the change: social (status (#371), #371: a local Bot's hold shows in its own chat… for hidden / gone / absent / home-level / listed, en + zh) and core (channel: a local Bot gets pendingCount…). ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify green.

T3 (plugins/social/src/social.js): needs an independent PASS and your approval; not merged. No deploy.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-18T15:02:58.502640Z	09f8644	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.