Repository navigation
fix(rooms): a missing or refused clipboard shows the invite link instead of claiming it was copied - #331
fix(rooms): a missing or refused clipboard shows the invite link instead of claiming it was copied#331Birfy wants to merge 1 commit into
Conversation
…ead of claiming it was copied Codex review on ThinkFlowLab#321: with no navigator.clipboard (insecure context, locked-down WebView) the optional-chained await resolved and the card said 'copied' while the link, minted for this click, was shown nowhere. Now a missing API or a refused write puts the link itself in the note (wrapping, selectable).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06bc7af551
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| : await navigator.clipboard.writeText(link).then(() => true, () => false) | ||
| setFixNote(copied | ||
| ? t('Invite link for {name} copied. Send it to your friend; once they accept, create the group again.', { name: bot.name }) | ||
| : t('Send this invite link for {name} to your friend; once they accept, create the group again: {link}', { name: bot.name, link })) |
There was a problem hiding this comment.
The clipboard-failure branch changes what users see, but I checked the full 3e9c47a changed-file list and it neither adds nor updates a changelog.d fragment. Record this in a .fixed.md fragment (or update the existing unreleased group-friend-bot-refusal fragment) so release notes include it; repository policy requires a fragment for user-visible changes.
AGENTS.md reference: AGENTS.md:L20-L20
Useful? React with 👍 / 👎.
Follow-up to #321 (merged), resolving Codex's P2 on
core/src/client/new-chat.js.With no
navigator.clipboard(insecure context, locked-down WebView) the optional-chainedawait navigator.clipboard?.writeText(link)resolved, so the refusal card said Invite link for {Bot} copied while the link — minted for that click and shown nowhere else — never reached the clipboard.Now a missing API or a refused write is not a copy: the note shows the link itself (
Send this invite link for {name} to your friend; once they accept, create the group again: {link}, zh added), wrapping and selectable (.bt-fix .bt-note). Same rule asfeedback.jscopy(). Client-only; regeneratedcore/client.js+ patches;new-chat.test.jspins it;docs/subsystems/core-client.mdupdated.Ran at tip:
TZ=UTC ARCH_DOCS_BASE=upstream/main npm run verifygreen (Node 24).