[HugoXK]

Fixes #2232

Owner: Dev-1
Written-by: Dev-1
Reviewer: Birfy
Claim-Id: cf7d59a6986a47338e5efc88cb027219
Branch: dev/2-p451-schedules-readonly
Base: 9863992
Tier: T1 (path table: core/src/client/** = T1)
Tree: dc4b87e14cade7b49c4862cfe4ae428a9b0f3261
Head: 88f45d7
Single parent: 9863992
Verified commit: 03e1dc74e1da15575811ac738396716c65369a9d (tree dc4b87e14cade7b49c4862cfe4ae428a9b0f3261); the pushed head is generated from that tree by the push path

What changes

core/src/client/schedules.js never read the window lock, so Settings → Scheduled tasks drew every
write the host refuses in a read-only window, and the refusals it did hit were dropped. Three parts:

A. The lock is read once, the way the rest of the client reads it.
typeof roster.readOnly === 'string' && roster.readOnly.trim() !== '', the same test as
sidebar.js, settings.js and workflows.js. SchedulesPage reads it and passes it down; a locked
page draws no write control — no Turn on/Turn off, no Quiet hours window fields or
Save window, no New task and no create form, and no Edit, Copy, Pause/Resume,
Delete or Retry on a row. They are not rendered rather than disabled: a disabled button still
tells the reader this window can do it. The Quiet hours card keeps its state line (Off /
On, 22:00–07:00) and its hint, which are reads. The page draws no read-only sentence of its
own: the Settings header already carries it (settings.js .bt-hint.bt-read-only, #2199), and a
second copy would announce twice. BotSchedules (a Bot's settings card) keeps its New task row —
it only calls actions.openSettings('schedules', bot.id) and writes nothing — while its inline
Edit no longer opens the form in a locked window.

B. A refused Pause, Resume, Delete or Retry says so. TaskRow had one refusal slot for Retry and
dropped every other rejection (remove and toggle only cleared busy). It now has one rowError
for all four: the host's own sentence via hostText(error?.message ?? String(error)), drawn in the
slot Retry already had, as role="alert". It is cleared at the start of the next attempt and on
success, so a row carries at most one sentence. A successful Pause still republishes the host's
answer through onView and says nothing.

C. Two visible refusals become announcements. The Quiet hours card's error line and the create
form's error line already printed the host's sentence but carried no role; both are role="alert"
now. Wording is unchanged.

This is not read-only-only: a writable window whose row went stale (another window deleted or moved
the task) hits the same remove/toggle paths, and those were silent there too.

Docs: the core/src/client/schedules.js row of docs/subsystems/core-client.md gains the locked
window and the row alert, and extends its existing "the host's named refusal appears on the form's
error line" sentence to say that line is an alert. Changelog:
changelog.d/2232-schedules-read-only.fixed.md. core/client.js and patches/ds-bot/* are
regenerated from these sources.

Red first

The five new tests are in core/test/schedules-client.test.js; the file runs 49, the 44 on the base
plus these five. They read the real schedules.js bundle with the suite's own renderer, and they can
see what a refusal tried to say because the test's useState stub now records the values handed to
a setter (the stub never re-renders, so state is read from a seeded render as the older tests do).

Before the change, with the final tests in place on 98639924 (sources at the base):

not ok 45 - #2232: a read-only window draws no scheduled-task write control
    a read-only window offers no scheduled-task write, saw Turn off,Save window,New task,Edit,Copy to another Bot or group chat,Pause,Delete task
not ok 46 - #2232: a refused Pause, Resume or Delete says the host sentence in that row, once
    Pause: the host sentence reaches the row, saw [true,false]
not ok 49 - #2232: Quiet hours and the form announce a refusal, not only print it
    one alert on the Quiet hours card
    0 !== 1
# tests 49 / # pass 46 / # fail 3

Reading each:

• 45 lists seven controls because this mount is the strict one: Quiet hours on (so
  Turn off, Save window and the two time fields exist) and an actions set that carries
  scheduleCreate (so Copy exists). The probe's five — Turn on, New task, Edit,
  Pause, Delete task — are a subset of these seven. The same test's writable control then
  asserts all seven are drawn there, so the empty list is the lock and not a page that failed to
  render.
• 46 is the swallowed refusal itself: on the base the rejected schedulePause reaches the row
  as [true, false] — busy on, busy off — and the host's sentence never arrives. The test runs
  the same shape for Resume and Delete (the Delete click is the confirming one) and then
  renders the row with the sentence to count exactly one role="alert" in it.
• 49 is the missing announcement: on the base the Quiet hours refusal already reached the card's
  error state (visible text), but the tree holds 0 role="alert" nodes. The create form's error
  span is the same shape in the same source — h('span', { className: 'bt-danger bt-set-hint' }, error) with no role — and is asserted the same way after this one.

Two tests in the same file are green at the base on purpose, so the fix cannot pass by breaking the
old behaviour: 47 a successful Pause still calls onView with the host's answer and draws no
alert, and 48 a failed row keeps its Retry alert in that same slot.

After the change

Every check below ran on this tree (dc4b87e1…, single parent 98639924…).

node --test test/schedules-client.test.js in core/: 49 tests / 49 pass / 0 fail (44 at the
base; five are the addition).

npm test in core/: 2674 tests / 2674 pass / 0 fail (2669 at the base).

npm run verify — exit 0, 4554 tests / 0 fail:

suite	tests	fail
core	2674	0
social	563	0
tree	131	0
timeline	140	0
workflow	384	0
.github/scripts	599	0
interop	37	0
live-e2e	26	0

arch-docs: OK (8 changed file(s)); build-client --check exit 0; patches: ds-bot/ = Fei2411/DeepSeek-Bot@2b10c70 (tree 5834c00, v0.1.5), 10 patches apply cleanly in order, core/ equals ds-bot/ + patches/ds-bot/, patches/ds-bot/ is what generate writes (generate is a no-op);
changelog: 9 fragment(s) in changelog.d/ are well formed.

Ran: npm run build in core/ and node scripts/build-client.mjs --check; node scripts/ds-bot-patches.mjs generate, then check and canonical (both no-op after generate);
npm run verify with TZ=UTC ARCH_DOCS_BASE=986399246ff8c26bd418978785ce1199dbd239ca (core lint
including arch-docs and lint-plugins, build-client --check, the patch check, the core suite,
all four plugin suites, .github/scripts, interop and live-e2e); the five new tests on the base
sources with the fix removed; node .github/scripts/changelog.mjs check.
Not run: no real browser or running instance was opened — the lock, the refusals and the alerts were
exercised through the repository's own renderer; no smoke bench (this change touches neither
core/index.js nor core/src/host/); CI's package job (pack check, typecheck, actionlint) is
outside npm run verify.

Policy-sign is not written: none of the changed paths is in policy/gates.json gateFiles.

Coordinates

git diff --stat 98639924...HEAD names the eight files: core/src/client/schedules.js 73/…,
core/client.js 70/…, core/test/schedules-client.test.js 140/…, docs/subsystems/core-client.md
2, changelog.d/2232-schedules-read-only.fixed.md 1, and the three regenerated patches/ds-bot/
files (0001-core-fixes.patch, 0008-client-bundle.patch,
files/test/schedules-client.test.js).

Checkpoint

{
"pr": 2235,
"claim": "Dev-1",
"issue": 2232,
"summary": "A read-only window no longer draws any scheduled-task write: not the Quiet hours toggle, window fields or Save window, not New task or the create form, and not Edit, Copy, Pause/Resume, Delete or Retry on a row. The lock is read once, the way the rest of the client reads it, and controls are hidden rather than disabled; the page draws no second read-only sentence because the Settings header owns it. A rejected Pause, Resume, Delete or Retry now puts the host's own sentence on that row's single alert, and the Quiet hours and create-form error lines gained role=alert.",
"files": ["core/src/client/schedules.js", "core/client.js", "core/test/schedules-client.test.js", "docs/subsystems/core-client.md", "changelog.d/2232-schedules-read-only.fixed.md", "patches/ds-bot/0001-core-fixes.patch", "patches/ds-bot/0008-client-bundle.patch", "patches/ds-bot/files/test/schedules-client.test.js"],
"checks": { "ran": "TZ=UTC ARCH_DOCS_BASE=986399246ff8c26bd418978785ce1199dbd239ca npm run verify", "result": "green", "at": "88f45d7784f37c97a1849ce0b5da027fd1dff967" },
"next": "draft until FlyBot Test's advisory PASS at this tip, then ready"
}

[Birfy]

Verdict: PASS at 88f45d7
Written-by: Reviewer
Attestation: 88f45d7 role=Reviewer

Ran at this tip:

$ ln -sfn /data/esinst/node_modules p2235tip/core/node_modules
$ cd p2235tip/core && node --test test/schedules-client.test.js
# tests 49  # pass 49  # fail 0
$ cp -a p2235tip p2235red && cp p2235base/core/src/client/schedules.js p2235red/core/src/client/schedules.js
$ cd p2235red/core && node --test test/schedules-client.test.js
# tests 49  # pass 46  # fail 3

Red first, at this tip: with only core/src/client/schedules.js swapped back to its 98639924 blob (the tip's tests kept) the suite is 46/49 — not ok 45 (a read-only window drew Turn off,Save window,New task,Edit,Copy to another Bot or group chat,Pause,Delete task), not ok 46 (the refused Pause reached the row as [true,false] and the host sentence never did) and not ok 49 (the Quiet hours card held 0 role="alert"). 47 and 48 stay green on the base, so the lock and the refusal are what turn them, not the test. Back on the tip: 49/49.

Review points:

• The lock is read once per page as typeof roster?.readOnly === 'string' && roster.readOnly.trim() !== '', the same test sidebar.js / settings.js / workflows.js use, and passed down; the writes are not rendered rather than disabled, the read half (task list, On, 22:00–07:00, the hint) stays, and the page adds no second read-only sentence of its own — the Settings header owns that one (Settings: a read-only window never says so on the panel it is showing — eight pages offer write controls with no sentence explaining the refusal #2199). BotSchedules keeps its New task row (it only calls openSettings) and drops its inline Edit.
• One rowError slot per row for Pause, Resume, Delete and Retry, cleared at the start of the next attempt and on success, drawn in the slot Retry already had as role="alert"; a successful Pause still republishes through onView and says nothing. The Quiet hours error line and the create form's error line gained role="alert" with unchanged wording.
• Scope is what the PR declares: compare 9863992…88f45d7 is one commit on a single parent, 8 files / +688 / −312 — core/src/client/schedules.js, the generated core/client.js, the test, docs/subsystems/core-client.md, the changelog fragment and the three regenerated patches/ds-bot/ files. Nothing outside the issue's subject.
• Check-runs at this tip (17): all success — tests-ok, package, plugins (tree/social/workflow/timeline), ubuntu-latest · Node 24, risk tier, reviewed tip, merge-gate, enqueue-guard, judge, agent-audience. No failure.
• Checkpoint block is compliant: 1268 chars with markers, summary 572, next 63, 8 files all in this diff, at = this tip.

Not run here: the full core suite — this box has no dev/harness deps (jsdom, @deepseek-ai/dsh-llm), so only the affected suite and its red control were executed; tests-ok is green on this very tip. No browser or running instance was opened.

Non-blocking follow-up, not a reason to hold: in a locked window opened with a target (start set, i.e. the Bot card's New task row), adding stays true while the form is not drawn, so the page falls past the "No scheduled tasks yet." branch and draws an empty list under the Quiet hours card. It offers no write, so it is not this defect — but it is a blank surface worth a later issue.