Repository navigation
feat: own handle in account menu, clearer agent row, visible leave status (#181, #191) - #190
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Birfy
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc4ef1e8c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| return h('div', { className: 'fs-me', 'data-flybot': 'my-handle-menu' }, | ||
| h('span', { className: 'fs-me-handle', title: 'Your Bot Social handle' }, handle), | ||
| h('button', { type: 'button', className: 'fs-link', 'data-flybot': 'copy-my-handle', onClick: copy }, copied ? 'Copied' : 'Copy')) |
There was a problem hiding this comment.
Whenever a connected user's handle renders in the account portal, this button is a descendant of .bt-menu, so the rule in core/src/client/styles.js gives it width:100%, min-height:30px, and display:flex. The more-specific .fs-me .fs-link rule only sets flex:none, which makes Copy reserve the entire flex-row width and shrinks the handle span away or overflows the header, defeating the new handle display; add account-header-specific sizing overrides or limit the core rule to actual menu items.
Useful? React with 👍 / 👎.
| const copy = async () => { | ||
| const clip = typeof navigator !== 'undefined' ? navigator.clipboard : undefined | ||
| try { | ||
| await clip?.writeText?.(handle) |
There was a problem hiding this comment.
In browsers where navigator.clipboard is absent, such as an insecure non-local HTTP deployment, optional chaining resolves this await to undefined and execution still sets copied to true. The menu therefore says Copied even though no write was attempted, so users can paste stale clipboard contents; only show success after calling a supported writeText, and otherwise expose a fallback or failure state.
Useful? React with 👍 / 👎.
Fixes #181 (remaining items) and Fixes #191.
flybot.account.headerslot; socialMyHandle).FaceRoomStatus).