Repository navigation
fix(tree): stop drawing a retired Bot, and list it in Archived - #1796
Conversation
…archived (ThinkFlowLab#1793) `archive_bot` writes `retired: true`, and `forestOf` already skipped that Bot, but `treeOf` kept drawing it as a working member and `archivedOf` looked only at `archived` or a 归档-/Archive- name, so retiring a Bot changed nothing in the tree UI and its chat had no way back. The panel now skips it like the sidebar does, and the Archived section lists it with a `retired` tag.
4855797 to
b6e7287
Compare
|
Review request for this tip: |
|
Verdict: PASS at b6e7287 Ran at this tip: Red first, at the same suite: with
|
Fixes #1793
What
archive_botwritesfields['flybot-tree'].retired = true, and the sidebar's own tree (forestOf,plugins/tree/client.js:289) already skipped such a Bot — but the tree panel'streeOf(:17) never readretired, so the Bot stayed drawn as a working member, whilearchivedOf(:491) only looked atarchivedor a 归档-/Archive- name, so it was in neither list. Retiring a Bot from the core looked like it did nothing in the tree UI, and its chat had no way back from the Archive.treeOfnow takes the same one-lineretired === trueskip asforestOf;archivedOfalso accepts a retired Bot, andstatusOfgives it theretiredtag (a record that also carriesarchivedkeeps itsarchived/archived · merged into <name>tag).plugins/tree/is outside the patch chain:git statusshows nopatches/change andnode scripts/ds-bot-patches.mjs generatewas not run.Tip
b6e72873e0dd005295d0147aa21860c8069895794bbb000f991a9ae879585347c4cc9892278525aa7b8f81e15a803d54a13fe32d2c0bc2119e7f9333(livemainat push time —mainmoved twice while this branch was being built, and the branch was rebuilt on the newest tip each time with no file overlap; the pushed head's tree is4bbb000f, the same tree verified below). The issue names92a4cf262cb8, which is no longer in the upstream object store (git cat-file -t 92a4cf26fails,origin/mainis now past7b8f81e1) —mainwas rewritten upstream and the merge commit at that sha is gone, so the branch is cut from the current live tip.plugins/tree/client.js+9/−2,plugins/tree/test/archived-section.test.js+37,docs/subsystems/tree.md+1/−1,changelog.d/1793-tree-retired-archived.fixed.md+1 (new).Red first
On live
main(2213b4ca), with a probe over the existingarchived-section.test.jsharness (plugins/tree/test/probe-retired.test.js, carried only until the committed cases replaced it),node --import ./test/resolve.mjs --test test/probe-retired.test.js:With the fix the same probe lists
["Retired Dev"]and draws["Chief"]. The committed cases are#1793: a retired Bot leaves the tree and opens from the Archived section with a retired tag(the panel andforestOfagree, the row carriesretired, and clicking it opens that chat) and#1793: retired and archived stay distinct, and both are listed.Gates at this head
enqueue-guardat this tip says, verbatim:Its summary adds the line: the head lives in a fork: the issue reference and
agent-prrules are not asked of it — so only the missing Verifier report refuses this head.What I ran, at tree
4bbb000f99(local commit16ed9ee1, parent7b8f81e1; the pushed headb6e72873carries that same tree, checked throughGET /commits/b6e72873):TZ=UTC ARCH_DOCS_BASE=7b8f81e15a80 npm run verify— exit 0: core 2141, social 539, tree 127, timeline 129, workflow 289, .github 549, interop 37, live-e2e 24, 0 failures;arch-docs: OK (4 changed file(s));build-client --checkcleangit status— only the four files above; nopatches/change and nogeneraterunNot run: the smoke bench, the CI
packagejob, and any push other than this branch.maintainer_can_modify: true.