Repository navigation
fix(social): distinguishable room titles, chip stripping on Bot-to-Bot sends, task-linked holds (#132, #106, #111) - #148
Conversation
…n holds Two rooms with the same people no longer share Face-to-face room; Bot-authored own-chat followups drop session chips (including cross-owner); a send stamps meta.taskId so two working tasks get the right hold. Co-authored-by: Danyang Chen <birfychen@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 069029e3c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| import { socialFetch } from './mcp-client.js' | ||
| import { lookFromServer } from './look.js' | ||
| import { formatFaceRoomTitle } from '../../../core/src/shared/face-title.js' |
There was a problem hiding this comment.
When @flybot/social is installed from its release tarball, plugins/social/package.json#files includes only this package, so this relative import resolves to <profile>/node_modules/core/src/shared/face-title.js rather than the separately installed ds-bot package. Importing the packed plugin therefore throws ERR_MODULE_NOT_FOUND before apply can run; keep the helper inside the social package or expose it through an installed API.
AGENTS.md reference: AGENTS.md:L51-L52
Useful? React with 👍 / 👎.
Closes the concrete remainders of three open issues.
Face-to-face · Alice, Bob · 482913, or with the date and time when there is no code). The generic "Face-to-face room" fallback is gone.dsh-session:chips, including a granted Bot of another owner.bot.sendstampsmeta.taskId(origin match, else the latest working task), so a Bot with two or more working tasks gets the right hold.Not included: the
Tool removed: ask_user_questionline (#140, a DSH core cell) and the #111 clarification state andworkBotId(need #55).Fixes #132, Fixes #106, Fixes #111
ARCH_DOCS_BASE=upstream/main npm run verifypasses.