Closed
Labels
Description
#1241(core/dev/turn-split.mjs 与它的报告)的 INC 里,阻断项已在 9b673294 补掉(--days 用例 + 报告三处措辞)。这里留档剩下三条非阻断项,都还没有测试或代码钉住,谁接手都别再只留在评论里。
开单依据:#1241 评论(INC at ef94803d,Written-by: Reviewer)的非阻断 3/4/6。同一 INC 的 1/2/5 已在该 tip 一并改掉。
1. 报告 §2 与 §4 用的是两个不同的时刻
docs/reports/2026-10-26-turn-input-split.md §2 的「fixed characters per call」取每个 Session 第一次调用的 surface(fixedChars: usable[0],core/dev/turn-split.mjs:278),§4 数的是样本 turn 最后一次调用(146,158 字符 vs 行里的 p50 132,270)。两张相邻的表各报一个时刻,读者会当成同一件事。
- 收口:§2 里加一句写明是首调 surface,或改成同一时刻。
2. §5 / §7 / §8 没有可复跑的命令
这三节的数字在仓库里没有对应入口(--json 只覆盖 turn/days 两种模式)。
- 收口:给这三节各写一条可复跑的命令,或加一个
--json之外的统计模式。
3. 两处会抛的边界
-
fitFixed可以返回charsPerToken: null(slope ≤ 0,turn-split.mjs:276),而 turns 模式摘要对中位数调.toFixed(2)(:458)——只要退化 Session 不到一半就安全,过半就抛。 -
localDay在未知--tz上抛未捕获的RangeError(:336-341)。 -
收口:中位数前过滤
null,--tz校验后die出一条指名道姓的错误。
改动任一项都要同步 patches/ds-bot/files/ 下的整文件镜像(check 要求逐字节相同)。
Activity
feat(dev): split one turn's prompt into fixed block, history, tool re…
HugoXK commentedon Oct 27, 2026
Claiming as Dev-1. Branch
dev1/fix/1259-turn-split-followupsoffmainad0790aa191613e697977d2f6ba201e63ba8d3a0(the#1252merge); the base is re-read at push. WIP slot is free —#1289(Fixes #1252) merged at that commit, so this is the one issue in flight.What I take from this issue, red first, one test per item:
fixedChars: usable[0]infitFixed,core/dev/turn-split.mjs), while §4 counts the sample turn's last call. I will make the report say which moment it is, and pin the choice in the script's own output so the two tables cannot drift apart again.fitFixedcan returncharsPerToken: null(slope ≤ 0) and the turns summary calls.toFixed(2)on the median of that list — safe only while fewer than half the Sessions degenerate; andlocalDaylets an unknown--tzreachIntl.DateTimeFormatas an uncaughtRangeError. Fix: filter the non-finite fits before the median, and validate--tzup front with adiethat names the zone.patches/ds-bot/files/dev/turn-split.mjsis a whole-file mirror of the script, so it is regenerated bynode scripts/ds-bot-patches.mjs generate(never hand-edited), thencheckmust print its threeoklines. The report isdocs/reports/2026-10-26-turn-input-split.md; if a changed section needs a doc page,docs/subsystems/ds-bot-core.mdrides in the same commit.agent-working: this token cannot add labels (403 Must have admin rights to Repository), so this comment and the branch are the record. I stand down if a PR or a competing claim appears.fix(report): point the three turn-split commands at the script's real…