Repository navigation
Face room listed in both active list and Past rooms as Closed #1070
Description
Reproduce
Face-to-face rooms on tip → social.botawaken.com, 2026-10-25 continue:
- Create / join face rooms (e.g. 582914 on A, 846271 on B).
- Leave one room → confirm it appears under Past rooms as Left.
- Inspect rooms that were closed (not left by this side).
Expected
A room is either in the active face list or in Past rooms, not both. Closed rooms leave the active list.
Actual
Rooms 582914 (A) and 846271 (B) appear in both the active list and Past rooms as "Closed". Past-rooms timestamps also differ between A and B for the same room (e.g. 582914: 21:22 on A vs 21:28 on B).
Leave → Past "Left" path itself works.
Environment
- Social: https://social.botawaken.com
- Shots:
/workspace/social-ui-deep-test/continue/
Suggested scope
When a face room is Closed (or Left), remove it from the active list; keep a single Past-rooms entry. Align timestamps if they should be shared.
Source
product UI deep-test continue 2026-10-25 (owner: file + fix)
Activity
Mark a vanished face room Closed so it leaves the active list
Mark a vanished face room Closed so it leaves the active list
Birfy commentedon Oct 25, 2026
done— four checks on3f7e9515(the merge of this PR):#1070isclosed/completed;Fixes #1070->#1080; merge commit3f7e9515, merged from84eb8bea.changelog.d/1070-closed-face-room-leaves-active-list.fixed.mdis in main (291 bytes).docs/subsystems/social.mdcarries the sentence added here ("A room that drops off Bot Social's list without this home leaving is the same end (Face room listed in both active list and Past rooms as Closed #1070)…").plugins/social/src/social.jsmarks the hosted roomclosedand keeps one Past-rooms row; the tests#1070added are in main.Also checked on
3f7e9515, since the INC on84eb8beasaid this PR would delete the#1046test:grep -c "#1046" plugins/social/test/social.test.jsis 2 and#1070is 2 — the merge kept both. The "28 deletions" is what a diff against the PR's stated base (43e55792) shows; the squash merge is a three-way merge, so a test that landed after that base stays. I reproduced the same merge locally (base43e55792, ours84eb8bea, theirs main) and got the same two occurrences.