Skip to content

as: Append device attributes to service data uplink#7524

Merged
vlasebian merged 1 commit into
v3.34from
feat/service-data-dev-attr
Mar 3, 2025
Merged

as: Append device attributes to service data uplink#7524
vlasebian merged 1 commit into
v3.34from
feat/service-data-dev-attr

Conversation

@vlasebian
Copy link
Copy Markdown
Contributor

Summary

References #5879.

Changes

  • Append device attributes to ServiceData message

Testing

Steps
  • Launch TTS, create an application and an end device
  • Set device attributes in the settings view of the end device
  • Simulate a service uplink data message
  • Check the uplink message in the live data view of the end device
Results
Screenshot 2025-03-03 at 15 38 07
Regressions

None.

Notes for Reviewers

None.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@vlasebian vlasebian self-assigned this Mar 3, 2025
@vlasebian vlasebian requested a review from a team as a code owner March 3, 2025 13:38
@vlasebian vlasebian requested a review from johanstokking March 3, 2025 13:38
@github-actions github-actions Bot added the c/application server This is related to the Application Server label Mar 3, 2025
@vlasebian vlasebian force-pushed the feat/service-data-dev-attr branch from cdaec2f to 96c38d4 Compare March 3, 2025 14:31
@vlasebian vlasebian merged commit 516c787 into v3.34 Mar 3, 2025
@vlasebian vlasebian deleted the feat/service-data-dev-attr branch March 3, 2025 14:55
@KrishnaIyer
Copy link
Copy Markdown
Member

@vlasebian doesn't this need to backported to the current release?

@vlasebian
Copy link
Copy Markdown
Contributor Author

Yes, this needs to be backported to the current release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/application server This is related to the Application Server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants