Skip to content

chore: Remove empty braces in macros to help clang format#2883

Merged
xezon merged 2 commits into
TheSuperHackers:mainfrom
githubawn:fix/remove-empty-macro-braces
Jul 19, 2026
Merged

chore: Remove empty braces in macros to help clang format#2883
xezon merged 2 commits into
TheSuperHackers:mainfrom
githubawn:fix/remove-empty-macro-braces

Conversation

@githubawn

Copy link
Copy Markdown

In preparation for the clang format PR. This removes all empty braces from the source to avoid formatting issues.

@greptile-apps

greptile-apps Bot commented Jul 17, 2026

Copy link
Copy Markdown

Greptile Summary

This PR cleans up disabled debug macro definitions before clang-format work. The main changes are:

  • Removed empty brace bodies from no-op logging macros.
  • Updated disabled CRC, assert, and tool debug macros to empty replacements.
  • Applied the same cleanup across shared Core code and Generals/Zero Hour forks.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
Core/GameEngine/Include/Common/CRCDebug.h Disabled CRC debug macros now expand to empty replacements.
Core/Libraries/Source/debug/internal.h The disabled internal assert macro now expands to an empty replacement.
Core/Tools/Launcher/wdebug.h Disabled Launcher debug macros now expand to empty replacements.
Core/Tools/mangler/wlib/wdebug.h Disabled mangler wlib debug macros now expand to empty replacements.
Core/Tools/matchbot/wlib/wdebug.h Disabled matchbot wlib debug macros now expand to empty replacements.

Reviews (3): Last reviewed commit: "chore: remove empty braces" | Re-trigger Greptile

@xezon xezon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a few are missing, for example in wdebug.h files

@githubawn
githubawn force-pushed the fix/remove-empty-macro-braces branch from b4e6db9 to b359495 Compare July 18, 2026 16:57
@xezon xezon changed the title chore(clang-format): remove empty braces chore: Remove empty braces in macros to help clang format Jul 19, 2026
@xezon xezon added the Refactor Edits the code with insignificant behavior changes, is never user facing label Jul 19, 2026

@xezon xezon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@xezon
xezon merged commit 69e1ea2 into TheSuperHackers:main Jul 19, 2026
17 checks passed
atraber pushed a commit to atraber/GeneralsGameCode that referenced this pull request Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Edits the code with insignificant behavior changes, is never user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants