Create adaptive_merge_sort.py#11993
Conversation
algorithms-keeper
Bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| return sequence | ||
|
|
||
|
|
||
| def adaptive_merge_sort_helper(array: list, aux: list, low: int, high: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: adaptive_merge_sort_helper. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file sorts/adaptive_merge_sort.py, please provide doctest for the function adaptive_merge_sort_helper
| merge(array, aux, low, mid, high) | ||
|
|
||
|
|
||
| def merge(array: list, aux: list, low: int, mid: int, high: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: merge. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file sorts/adaptive_merge_sort.py, please provide doctest for the function merge
for more information, see https://pre-commit.ci
algorithms-keeper
Bot
removed
require tests
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,92 @@ | |||
| def adaptive_merge_sort(sequence: list) -> list: | |||
| """ | |||
There was a problem hiding this comment.
An error occurred while parsing the file: sorts/adaptive_merge_sort.py
Traceback (most recent call last):
File "/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line 146, in parse
reports = lint_file(
^^^^^^^^^^
libcst._exceptions.ParserSyntaxError: Syntax Error @ 2:5.
parser error: error at 1:4: expected one of (, *, +, -, ..., AWAIT, EOF, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~
"""
^for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
algorithms-keeper
Bot
removed
the
tests are failing
|
@algorithms-keeper[bot] approve this please........ |
1 participant
Describe your change:
Checklist: