sets ICB column to NATIONAL for national runs - #473
Conversation
✅ A new build is available.You can use the following to use pull the image into your local environment: docker pull ghcr.io/the-strategy-unit/nhp_model:pr-473 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 1017 1017
Branches 50 50
=========================================
Hits 1017 1017 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yiwen-h
left a comment
There was a problem hiding this comment.
PR text says "icb" column was renamed but code is changing "imd" column instead?
|
More haste, less speed... will fix! |
|
Also we need an issue for this PR if that's ok just outlining the problem we're trying to fix. Thank you! |
temporary patch to reduce the number of rows. #468 would be the better approach longer term. without this need to massively increase available memory on the cluster.
27277e8 to
c4d8329
Compare
|
Sorry for dumb q but how do I test this? Could we create a .whl with this branch that I install on my cluster to test? |
yiwen-h
left a comment
There was a problem hiding this comment.
Looks good to me for now but we will need ICB for inequalities, soon. Just a note to self for later!
temporary patch to reduce the number of rows. #468 would be the better approach longer term.
without this need to massively increase available memory on the cluster.