Skip to content

sets ICB column to NATIONAL for national runs - #473

Merged
tomjemmett merged 1 commit into
mainfrom
drop_icb_from_national_data
Aug 21, 2025
Merged

tomjemmett merged 1 commit into
mainfrom
drop_icb_from_national_data

Conversation

@tomjemmett

Copy link
Copy Markdown
Member

temporary patch to reduce the number of rows. #468 would be the better approach longer term.

without this need to massively increase available memory on the cluster.

@tomjemmett
tomjemmett requested a review from a team as a code owner August 20, 2025 08:38
@tomjemmett tomjemmett added this to the v4.1.0 milestone Aug 20, 2025
@tomjemmett tomjemmett added enhancement New feature or request priority: should We should implement this feature labels Aug 20, 2025
@tomjemmett tomjemmett self-assigned this Aug 20, 2025
@tomjemmett
tomjemmett requested a review from yiwen-h August 20, 2025 08:38
@github-actions

github-actions Bot commented Aug 20, 2025 •

Copy link
Copy Markdown

✅ A new build is available.

You can use the following to use pull the image into your local environment:

docker pull ghcr.io/the-strategy-unit/nhp_model:pr-473

@codecov

codecov Bot commented Aug 20, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7a9aa54) to head (c4d8329).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #473   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines         1017      1017           
  Branches        50        50           
=========================================
  Hits          1017      1017           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yiwen-h yiwen-h left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR text says "icb" column was renamed but code is changing "imd" column instead?

@tomjemmett

Copy link
Copy Markdown
Member Author

More haste, less speed... will fix!

@yiwen-h

yiwen-h commented Aug 20, 2025

Copy link
Copy Markdown
Member

Also we need an issue for this PR if that's ok just outlining the problem we're trying to fix. Thank you!

temporary patch to reduce the number of rows. #468 would be the better approach longer term.

without this need to massively increase available memory on the cluster.
@tomjemmett
tomjemmett force-pushed the drop_icb_from_national_data branch from 27277e8 to c4d8329 Compare August 20, 2025 10:12
@tomjemmett tomjemmett linked an issue Aug 20, 2025 that may be closed by this pull request
@yiwen-h

yiwen-h commented Aug 20, 2025

Copy link
Copy Markdown
Member

Sorry for dumb q but how do I test this? Could we create a .whl with this branch that I install on my cluster to test?

@yiwen-h
yiwen-h self-requested a review August 21, 2025 13:37

@yiwen-h yiwen-h left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for now but we will need ICB for inequalities, soon. Just a note to self for later!

@tomjemmett
tomjemmett merged commit 8c0b630 into main Aug 21, 2025
8 checks passed
@tomjemmett
tomjemmett deleted the drop_icb_from_national_data branch August 21, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: should We should implement this feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop ICB column from national run data

2 participants