Sometimes can added, sometime shows send to review

[Carolyn-Jiang]

[Carolyn-Jiang]

I can edit other people's skills, but when I edit my own, I need review, and am unable to edit the working group leader, chapter officers and Zhuoran Lu's skill. Unable to change anybody's available time. Please write a clear README in the GitHub repo about Chapter Officers and Work Group Learners' permission. Also, highlight who the request will be sent to (e.g., the president) for review and how long the review will take.

[jiminHuang]

Thanks — three separate things here:

1. 'Unable to change anybody's available time' — that was the broken Save button (Still no save Button #43); fixed and pushed.
2. 'Edit my own → review, edit others → direct' — that's intended: an officer's edits to a card they manage apply immediately, but a member editing their own card submits it for officer review (issue People Management Workflow, Resource Model, and Permission System Are Incomplete and Inconsistent #40 B). The inconsistency you felt between those two is the design, not a bug — though we'll label it more clearly.
3. 'Cannot edit the WG leader / chapter officers' / Zhuoran's skills' — this is a real permission gap: skill edits are currently only permitted for member cards (and yourself), so editing other claimed members/officers is blocked at the backend. Fixing this needs a permissions change + a decision on exactly who may edit whom (e.g. should a chapter officer edit any claimed member in their chapter? other officers?). We're scoping it together with People Management System Audit: Permissions, Persistence, Resource Model, and Terminology #41.

On your README request: we'll publish a clear permissions doc (Chapter Officer vs WG Leader vs First Author, what each can create/edit/undo, who reviews self-submitted changes). Good call.

[jiminHuang]

Permission fixed — chapter officers can now edit any registered member in their chapter (skills, level, hours), not just unclaimed cards. The edit gate (can_edit_member) now also allows 'an officer of the member's home chapter', and those edits apply directly (a plain member editing their own card still goes to review). Live after the next deploy + db push. (We also caught and fixed a related store-timing bug where edit controls didn't appear until a refresh.)

[jiminHuang]

Permissions reference published: docs/permissions.md in the repo — the three roles (Chapter Officer / Working Group Leader / First Author + Admin), what each can create / edit / remove, and crucially where your edits go: an officer's edits apply directly; a member's edit of their own card goes to their chapter officer for Approve/Reject (it waits in a 'Changes awaiting your review' panel on the member's profile — one click, no fixed time limit); new resources go to a steward. Also clarifies Available time vs resources.