Repository navigation
Conversation
boost::filesystem::copy_option was removed in newer Boost versions, use copy_options::none, which is the same as the removed fail_if_exists.
Member
|
please adjust this part to be sync with what TC does here: https://github.com/TrinityCore/TrinityCore/blob/49bd093968e6ed7a662d44c7c10653800bfc23e6/src/server/game/Scripting/ScriptReloadMgr.cpp#L860 |
Contributor
Author
|
Done, the call now matches upstream ( |
Ovahlord
merged commit Oct 17, 2026
dd88995
into
The-Cataclysm-Preservation-Project:master
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
fs::copy_fileinHotSwapScriptReloadMgr::ProcessLoadScriptModule, in sync with TrinityCore. The oldfs::copy_option::fail_if_existsenum is gone in newer Boost versions (tested with 1.90), and the default behavior (error if the target exists) is what the call relied on.Target branch(es): 4.3.4
Issues addressed: The worldserver fails to build with
-DSCRIPTS=dynamic:error: 'fs::copy_option' has not been declared; did you mean 'fs::copy_options'?Tests performed: Built
ScriptReloadMgr.cppwith Boost 1.90 and-DSCRIPTS=dynamic. Not tested with Boost versions below 1.90.