feat: Add Visibility properties to IWeatherData (Fixes CIR-1090) - #41
Merged
Merged
Conversation
Adds visibility native extraction in meters. Updates provider mappers to extract visibility correctly: - OpenWeather: mapped implicitly 1:1 if present - Tomorrow.io: km to meters multiplier applied - Weatherbit: km () to meters mapped - NWS: native conversion in wmoUnit:m Includes end-to-end mocked unit tests to guarantee 100% path coverage on visibility maps.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
victorquinn
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://linear.app/texture/issue/CIR-1090/feature-add-visibility-properties-to-iweatherdata
This PR completes the triad of fleet-routing data requested by logistics evaluators by adding
visibility(measured cleanly normalized intometers).Includes full end-to-end extraction from native provider properties:
Verified locally with 197 passing tests and 100% statement coverage so CI checks shouldn't hang.