fix: harden v4 live-order paths and sync docs for 4.0.1 - #110
Merged
Conversation
Stop retrying mutating broker POSTs and raise OrderSubmissionUncertainError on timeout, disconnect, 5xx, or cancel after send. Restore SignalR subscriptions after stale-feed reconnect, and fall back from native brackets when child orders cannot be uniquely resolved. Also fix POST /Order/search recovery, partial fill reporting, tolerant Account/Instrument constructors, max_order_size enforcement, JWT-free hub task names, HTTPS URL validation, and align README/docs/CI with 4.0.1.
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
CI failed because setup tests still asserted the pre-v4 with_url(url) signature. pysignalr hubs are now named "user" and "market".
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-v4.0.0 hardening so the SDK is safer for live orders and the docs match 4.0.1.
/Order/place|cancel|modify, position close) are not retried. Timeout, disconnect, 5xx, or cancel after send raisesOrderSubmissionUncertainError.POST /Order/search. Fill checks report partial fills when original size is known.Account.from_api()/Instrument.from_api(),filledSize→fillVolume, failed position/trade searches raise instead of returning[].max_order_sizewhen validation is on, reject remotehttp://URLs, applyrequests_per_minuteto the limiter, disable HTTP redirects.release.ymlis GitHub Release only; PyPI stays onpublish-pypi.yml. Hatch uses dynamic version from__init__.py.Plan:
docs/superpowers/plans/2026-08-29-v4-hardening.mdTest plan
pyteston HTTP, orders, brackets, tracking, realtime health, models, config, auth (297 passed)POST /Order/placeis one attempt andOrderSubmissionUncertainError