Developer-fixed test from spring-data-envers - #294
Merged
darko-marinov merged 2 commits intoNov 26, 2021
Conversation
This test's order-dependence was accidentally fixed by virtue of a change from JUnit 4 to JUnit 5, which altered an annotation on a `setUp` method from `@Before` to `@BeforeEach`, thus clearing dirty state between two tests in the affected class regardless of which one ran first.
pthariensflame
added a commit
to pthariensflame/idoft
that referenced
this pull request
Dec 5, 2021
Previously this wasn't happening, as visible in TestingResearchIllinois#294.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test's order-dependence was accidentally fixed by virtue of a change from JUnit 4 to JUnit 5, which altered an annotation on a
setUpmethod from@Beforeto@BeforeEach, thus clearing dirty state between two tests in the affected class regardless of which one ran first.