Repository navigation
test: avoid DriveInfo.GetDrives() crash on macOS in simulated DriveInfo.Wrap test - #1168
Merged
Merged
Conversation
…fo.Wrap test The macOS unit tests crashed the test host with an AccessViolationException inside System.IO.DriveInfo.GetDrives(). The existing Test.RunsOnMac skip did not apply, because in simulated mock rows Test reflects the simulated OS, so the Linux and Windows simulations on a macOS host still called GetDrives(). The test only needs any DriveInfo to pass to Wrap, so it now creates one from the root of the temp path, which also lets it run on macOS.
|
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Test Results 62 files ±0 62 suites ±0 1h 17m 41s ⏱️ + 2m 40s Results for commit 37f0a25. ± Comparison against base commit a856b45. This pull request removes 63024 and adds 63020 tests. Note that renamed tests count towards both.This pull request removes 3484 skipped tests and adds 3484 skipped tests. Note that renamed tests count towards both. |
|
This is addressed in release v7.2.0. |
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS unit tests crashed the test host with an AccessViolationException inside System.IO.DriveInfo.GetDrives(). The existing Test.RunsOnMac skip did not apply, because in simulated mock rows Test reflects the simulated OS, so the Linux and Windows simulations on a macOS host still called GetDrives(). The test only needs any DriveInfo to pass to Wrap, so it now creates one from the root of the temp path, which also lets it run on macOS.