Skip to content

chore: align the editor settings and the docs-site trigger with the other repositories - #1135

Merged
vbreuss merged 2 commits into
mainfrom
chore/align-editorconfig-and-docs-trigger
Oct 18, 2026
Merged

vbreuss merged 2 commits into
mainfrom
chore/align-editorconfig-and-docs-trigger

Conversation

@vbreuss

@vbreuss vbreuss commented Oct 18, 2026

Copy link
Copy Markdown
Member

Testably.Abstractions was the only repository with its own .editorconfig and its own trigger for the docs site, so the code style differed from the other Testably repositories and the site was rebuilt on every change below Docs/pages/docs, even when the build of that commit failed. The editor settings are now those of the other repositories, and the site is only notified after a successful build on main, with the commit that was built.

@vbreuss vbreuss self-assigned this Oct 18, 2026
@vbreuss
vbreuss added this pull request to stack #1134 October 18, 2026 09:19
@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Test Results

     62 files       62 suites   1h 2m 25s ⏱️
 66 150 tests  59 197 ✅  6 951 💤 2 ❌
151 204 runs  132 063 ✅ 19 139 💤 2 ❌

For more details on these failures, see this check.

Results for commit 208864c.

♻️ This comment has been updated with latest results.

Every other repository is kept up to date by Dependabot, and Mergify merges its pull requests, so Renovate is replaced with the same configuration, grouped for the packages of this repository. Dependabot cannot freeze single entries of a package like Renovate did, so the lines of System.Threading.Channels and System.Linq.Async that older target frameworks need are frozen for all of their entries. The download and upload actions no longer need an exception, as they are pinned to current versions.

The tests use the latest aweXpect release, the line-ending rule for solutions targets `.slnx`, which replaced the `.sln` file it still named, and the team settings are named after the `.slnx` solution, so that Rider picks them up again.

The ignore rule for the temporary build files still named the `.nuke` folder from before the move to Fallout, so `.fallout/temp/` showed up as untracked.
…ther repositories

Testably.Abstractions was the only repository with its own `.editorconfig` and its own trigger for the docs site, so the code style differed from the other Testably repositories and the site was rebuilt on every change below `Docs/pages/docs`, even when the build of that commit failed. The editor settings are now those of the other repositories, and the site is only notified after a successful build on `main`, with the commit that was built.
@vbreuss
vbreuss force-pushed the chore/align-editorconfig-and-docs-trigger branch from 208864c to cf61f50 Compare October 18, 2026 11:17
Copilot AI balanced review requested due to automatic review settings October 18, 2026 11:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Base automatically changed from chore/align-repository to main October 18, 2026 11:17
@vbreuss
vbreuss merged commit 6eefc04 into main Oct 18, 2026
10 of 12 checks passed
@vbreuss
vbreuss deleted the chore/align-editorconfig-and-docs-trigger branch October 18, 2026 11:18
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

This is addressed in release v7.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants