Skip to content

test: verify the public API with aweXpect.Snapshots.PublicApi - #1131

Merged
vbreuss merged 1 commit into
mainfrom
test/public-api-snapshots
Oct 18, 2026
Merged

vbreuss merged 1 commit into
mainfrom
test/public-api-snapshots

Conversation

@vbreuss

@vbreuss vbreuss commented Oct 18, 2026

Copy link
Copy Markdown
Member

PublicApiGenerator does not describe newer C# features like extension members or params collections, and every repository repeated a hand-written helper that stores, compares and accepts the expected files.

The API tests now read the public API of every target framework with Roslyn through aweXpect.Snapshots.PublicApi and compare it as a snapshot, so a change is accepted like any other snapshot, with the explicit AcceptApiChanges test or AWEXPECT_ACCEPT_SNAPSHOTS=all.

PublicApiGenerator does not describe newer C# features like extension members or `params` collections, and every repository repeated a hand-written helper that stores, compares and accepts the expected files.

The API tests now read the public API of every target framework with Roslyn through `aweXpect.Snapshots.PublicApi` and compare it as a snapshot, so a change is accepted like any other snapshot, with the explicit `AcceptApiChanges` test or `AWEXPECT_ACCEPT_SNAPSHOTS=all`.
@vbreuss vbreuss self-assigned this Oct 18, 2026
Copilot AI balanced review requested due to automatic review settings October 18, 2026 08:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vbreuss
vbreuss enabled auto-merge (squash) October 18, 2026 08:21
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Test Results

     62 files  ±0       62 suites  ±0   1h 2m 41s ⏱️ - 2m 11s
 66 156 tests +6   59 203 ✅ +4   6 951 💤 ±0  2 ❌ +2 
151 204 runs  ±0  132 063 ✅  - 2  19 139 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit e9118f7. ± Comparison against base commit b620438.

This pull request removes 63032 and adds 63037 tests. Note that renamed tests count towards both.
  )
)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(0033aad9-3ed9-4603-85bf-aa7827a09503)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(0453571a-5884-47a9-8c20-f61008db3209)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(2b3b6249-ca0e-4b2e-8bb9-7d6893f3d90f)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(3158cbbe-b6a3-4627-be1d-17b3f497ba0e)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(3455989e-a913-449d-ac5e-7d7a39668108)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(45c72490-8058-4f17-a97a-435d23244451)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(467b1dfb-860b-430b-bc59-5187b18f998c)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(55c4e6da-22f1-4b37-8489-25715256385f)
…
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(13f92c1c-10be-43a8-8d09-a7591b04465c)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(20600736-217c-44aa-be6a-de8879aac92f)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(281e2833-3987-4d12-a3d8-9d3dd0fd3ab5)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(3e1c3399-4724-4839-9bf7-b703948595af)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(45d81dd1-6b0a-4c75-8dad-621d14bc0a13)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(51d83fce-baf5-4582-b696-dbb86eb5fa7c)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(5f5f2089-2b54-41a4-9c05-fb8ee50d4ee0)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(6ab0fdff-fc3a-4757-954a-0fb0421b55cd)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(75dcf0c6-8c6c-4427-84e3-cac1b853ea5d)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(8e6b43ca-9a50-4618-9a29-237b442a5633)
…
This pull request removes 6893 skipped tests and adds 6893 skipped tests. Note that renamed tests count towards both.
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(0033aad9-3ed9-4603-85bf-aa7827a09503)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(0453571a-5884-47a9-8c20-f61008db3209)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(2b3b6249-ca0e-4b2e-8bb9-7d6893f3d90f)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(3158cbbe-b6a3-4627-be1d-17b3f497ba0e)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(3455989e-a913-449d-ac5e-7d7a39668108)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(45c72490-8058-4f17-a97a-435d23244451)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(467b1dfb-860b-430b-bc59-5187b18f998c)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(55c4e6da-22f1-4b37-8489-25715256385f)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(6966f4f2-b628-4942-9006-a8b86ab116f7)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(9a7cbb53-1f33-4be4-840b-cf3a1a60a9d1)
…
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(13f92c1c-10be-43a8-8d09-a7591b04465c)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(20600736-217c-44aa-be6a-de8879aac92f)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(281e2833-3987-4d12-a3d8-9d3dd0fd3ab5)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(3e1c3399-4724-4839-9bf7-b703948595af)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(45d81dd1-6b0a-4c75-8dad-621d14bc0a13)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(51d83fce-baf5-4582-b696-dbb86eb5fa7c)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(5f5f2089-2b54-41a4-9c05-fb8ee50d4ee0)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(6ab0fdff-fc3a-4757-954a-0fb0421b55cd)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(75dcf0c6-8c6c-4427-84e3-cac1b853ea5d)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(8e6b43ca-9a50-4618-9a29-237b442a5633)
…

@vbreuss
vbreuss disabled auto-merge October 18, 2026 11:16
@vbreuss
vbreuss merged commit c7036da into main Oct 18, 2026
14 of 16 checks passed
@vbreuss
vbreuss deleted the test/public-api-snapshots branch October 18, 2026 11:16
@github-actions

Copy link
Copy Markdown

This is addressed in release v7.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants