Repository navigation
chore: publish to nuget.org via trusted publishing - #1120
Merged
Merged
Conversation
Short-lived OIDC credentials replace the long-lived NuGet API key secret.
There was a problem hiding this comment.
🟢 Approval recommended
The workflow correctly configures and consumes NuGet OIDC credentials in both publishing jobs.
0 open findings
What changed in this PR
Replaces long-lived NuGet API keys with short-lived OIDC credentials for package publishing.
Changes:
- Grants OIDC token permissions to publishing jobs.
- Authenticates through
NuGet/login@v1. - Uses the generated API key for NuGet pushes.
| File | Description |
|---|---|
.github/workflows/build.yml |
Migrates both package publishing jobs to trusted publishing. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Test Results 62 files ±0 62 suites ±0 1h 21m 15s ⏱️ -53s Results for commit 15535cf. ± Comparison against base commit 70f501b. This pull request removes 62981 and adds 62981 tests. Note that renamed tests count towards both.This pull request removes 6893 skipped tests and adds 6893 skipped tests. Note that renamed tests count towards both. |
|
This is addressed in release v7.1.2. |
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short-lived OIDC credentials replace the long-lived NuGet API key secret.