fix: align documented Node engine floor#84
Merged
zeshi-du merged 1 commit intoJul 2, 2026
Conversation
zeshi-du
approved these changes
Jul 2, 2026
zeshi-du
left a comment
Contributor
There was a problem hiding this comment.
Reviewed and verified — merging. Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Aligns the project-level Node engine declaration and contributor docs with the locked dependency graph enforced by the repo's committed .npmrc\ (\engine-strict=true).
The previous >=20\ claim allowed Node 20.0-20.18, Node 21, and early Node 22 releases, but
pm ci\ can fail before contributors can build or test because locked dev dependencies require the intersection ^20.19.0 || ^22.13.0 || >=24.
This updates:
Related issue
Refs hackathon CLI improvement bonus.
Type of change
Checklist
pm run lint\ and
pm run format:check\ pass.
pm run typecheck\ passes.
pm test\ passes and coverage stays at or above the 80% gate.
Notes for reviewers
Local verification was run on Windows with Node \�20.11.0, which intentionally no longer satisfies the updated engine range. To verify this metadata/docs-only change in the existing local environment, npm scripts were run with engine strict disabled:
pm --engine-strict=false run build\ passed
pm --engine-strict=false run typecheck\ passed
ode node_modules/prettier/bin/prettier.cjs --check package.json package-lock.json README.md CONTRIBUTING.md DOCUMENTATION.md\ passed
I did not mark the full test suite as passing because the current Windows environment previously failed unrelated symlink/path/permission tests. CI uses Node 22 and should be the authoritative full-suite check.