Skip to content

fix: align documented Node engine floor#84

Merged
zeshi-du merged 1 commit into
TestSprite:mainfrom
naufalfx805-source:fix/node-engine-floor
Jul 2, 2026
Merged

fix: align documented Node engine floor#84
zeshi-du merged 1 commit into
TestSprite:mainfrom
naufalfx805-source:fix/node-engine-floor

Conversation

@naufalfx805-source

Copy link
Copy Markdown
Contributor

What does this PR do?

Aligns the project-level Node engine declaration and contributor docs with the locked dependency graph enforced by the repo's committed .npmrc\ (\engine-strict=true).

The previous >=20\ claim allowed Node 20.0-20.18, Node 21, and early Node 22 releases, but
pm ci\ can fail before contributors can build or test because locked dev dependencies require the intersection ^20.19.0 || ^22.13.0 || >=24.

This updates:

  • root \package.json\ engine range
  • root package entry in \package-lock.json\
  • README badge, quickstart, and contributing copy
  • CONTRIBUTING and DOCUMENTATION prerequisites

Related issue

Refs hackathon CLI improvement bonus.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes existing behavior)
  • Documentation only
  • Build / CI / chore

Checklist

  • PR targets the \main\ branch.
  • Commits follow Conventional Commits.

  • pm run lint\ and
    pm run format:check\ pass.

  • pm run typecheck\ passes.

  • pm test\ passes and coverage stays at or above the 80% gate.
  • New behavior is covered by unit tests (mock-based; no network or credentials required).
  • No secrets, API keys, internal endpoints, or personal data are included.
  • User-facing changes are reflected in \README.md\ / \DOCUMENTATION.md\ where relevant.

Notes for reviewers

Local verification was run on Windows with Node \�20.11.0, which intentionally no longer satisfies the updated engine range. To verify this metadata/docs-only change in the existing local environment, npm scripts were run with engine strict disabled:


  • pm --engine-strict=false run build\ passed

  • pm --engine-strict=false run typecheck\ passed

  • ode node_modules/prettier/bin/prettier.cjs --check package.json package-lock.json README.md CONTRIBUTING.md DOCUMENTATION.md\ passed

I did not mark the full test suite as passing because the current Windows environment previously failed unrelated symlink/path/permission tests. CI uses Node 22 and should be the authoritative full-suite check.

@zeshi-du zeshi-du left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and verified — merging. Thanks for the contribution!

@zeshi-du zeshi-du merged commit a524702 into TestSprite:main Jul 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants