Skip to content

fix(help): include request-timeout in global flag guidance#41

Merged
zeshi-du merged 1 commit into
TestSprite:mainfrom
JerryNee:fix/request-timeout-global-help
Jul 2, 2026
Merged

fix(help): include request-timeout in global flag guidance#41
zeshi-du merged 1 commit into
TestSprite:mainfrom
JerryNee:fix/request-timeout-global-help

Conversation

@JerryNee

Copy link
Copy Markdown
Contributor

What

--request-timeout is a global flag, but it was missing from two pieces of global-flag guidance:

  • the helper that rephrases misplaced global flags after subcommands
  • the shared GLOBAL_OPTS_HINT footer appended to subcommand help text

Why

When a user places a known global flag after a subcommand, the CLI tries to turn Commander’s generic unknown option message into an actionable hint. --request-timeout should get the same treatment as --output, --profile, and --endpoint-url.

Changes

  • Add request-timeout to the global flag arity table as a value flag.
  • Include --request-timeout in the shared global options help footer.
  • Add regression tests for the rephrased misplaced-flag message.
  • Refresh help snapshots for the updated footer.

Verification

  • npx vitest run src/lib/render-error.test.ts test/help.snapshot.test.ts -u
  • npm run typecheck
  • npm run lint
  • npm run format:check
  • npm test

@zeshi-du

Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zeshi-du, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 60d7bc3d-e7cc-4154-bbe9-4e099bf9cd5e

📥 Commits

Reviewing files that changed from the base of the PR and between 15e95de and 234d3e0.

⛔ Files ignored due to path filters (1)
  • test/__snapshots__/help.snapshot.test.ts.snap is excluded by !**/*.snap
📒 Files selected for processing (3)
  • src/lib/output.ts
  • src/lib/render-error.test.ts
  • src/lib/render-error.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@zeshi-du zeshi-du left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and verified — merging. Thanks for the contribution!

@zeshi-du zeshi-du merged commit 7928b5c into TestSprite:main Jul 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants