-
Notifications
You must be signed in to change notification settings - Fork 5
Harden hosted MCP OAuth docs, challenge semantics, and e2e smoke tooling #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dodeja
wants to merge
1
commit into
main
Choose a base branch
from
codex/data-8540-workos-only-mcp-auth
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,22 @@ | ||
| # Terminal49 MCP Server - Environment Variables | ||
| # Copy this file to .env.local and fill in your credentials | ||
|
|
||
| # Terminal49 API Token | ||
| # Get your token from: https://app.terminal49.com/settings/api | ||
| T49_API_TOKEN=your_api_token_here | ||
|
|
||
| # Terminal49 API Base URL (optional) | ||
| # Default: https://api.terminal49.com/v2 | ||
| T49_API_BASE_URL=https://api.terminal49.com/v2 | ||
| # Terminal49 MCP Server - Environment Variables | ||
| # Copy this file to .env.local and fill in your credentials | ||
|
|
||
| # Legacy compatibility auth (still supported during migration) | ||
| # Get your token from: https://app.terminal49.com/settings/api | ||
| T49_API_TOKEN=your_api_token_here | ||
|
|
||
| # Upstream Terminal49 API base URL (optional) | ||
| # Default: https://api.terminal49.com/v2 | ||
| T49_API_BASE_URL=https://api.terminal49.com/v2 | ||
|
|
||
| # OAuth challenge metadata URL returned via WWW-Authenticate | ||
| T49_MCP_RESOURCE_METADATA_URL=https://api.terminal49.com/.well-known/oauth-authorization-server | ||
|
|
||
| # Internal fallback token verification endpoint (server-to-server) | ||
| T49_MCP_TOKEN_VERIFY_URL=https://api.terminal49.com/internal/mcp/token_principal | ||
| T49_MCP_INTERNAL_AUTH_TOKEN=replace-with-shared-internal-secret | ||
|
|
||
| # WorkOS MCP JWT verification settings | ||
| WORKOS_MCP_ISSUER=https://api.workos.com | ||
| WORKOS_MCP_AUDIENCE=replace-with-your-workos-audience | ||
| WORKOS_MCP_JWKS_URL=https://api.workos.com/sso/jwks/your-jwks-id |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OAuth branch is gated on
looksLikeJwt, so onlyBearertokens with exactly three dot-separated segments are treated as OAuth tokens. Any valid opaque OAuth access token will skip this path and be handled as legacy auth, which means it is rejected asInvalid client credentialswheneverT49_API_TOKEN/T49_MCP_CLIENT_SECRETis configured (or forwarded upstream as aTokenscheme when not configured). This breaks hosted OAuth clients that receive opaque access tokens.Useful? React with 👍 / 👎.