Repository navigation
Conversation
|
Go 侧的上传白名单里没有 sql,上传直接被拒,这个改动端到端不起作用 |
|
已在 8fd9535 补齐 Go 共享上传/导入白名单中的 sql,并同步前端 parser 元数据尚未加载时的默认白名单。新增回归从 CreateKnowledgeFromFile 实际入口验证 .sql / .SQL 可保存并进入 DocumentProcess 队列,同时保留 Python 的实际 SQL 文本提取测试。Go 相关 44 项测试/子用例、前端 3 项、Python 10 项通过,差异范围 golangci-lint 为 0 issues。SQL 仅作为文本知识文档解析,不执行其中的语句。 |
|
Current-head CI follow-up for The completed local frontend, parser and Go checks remain recorded in the test plan; they do not replace this incomplete integration job. Could a maintainer rerun the cancelled DocReader job? I have no upstream Actions write permission and have not changed assertions or workflow time limits in this PR. |
|
Merged main 94fae6d without rewriting history; the new head is 51ba9a5. The conflict resolution keeps main's shared import whitelist in internal/utils/import_filetypes.go and its service delegation. SQL is added at that shared source, not restored to the old service-local map. I also added SQL/.SQL coverage for the shared utility and included sql in main's exact shared-extension-set expectation. The original upload/enqueue, frontend and parser regressions remain intact; SQL is still parsed as document text only. Validation on this head: Go targeted upload/import/utilities passed 20 top-level tests (45 including subtests), frontend 4 tests passed, Python routing and actual SQL text extraction 10 tests passed, the utility strict TypeScript check passed, and scoped golangci-lint 2.13.2 reported 0 issues. Gofmt and the contribution diff check passed. Both the missing shared SQL membership and the pinned-set expectation were observed failing before their respective fixes; no assertion was weakened. I did not rerun the complete DocReader suite, full frontend vue-tsc/build, or a deployed HTTP/gRPC/database end-to-end environment. Local checks do not replace the new-head CI. The earlier cancelled DocReader run remains incomplete, not a code failure or a pass. AI assistance was used for this merge and validation. |
Description
Accept SQL files throughout the knowledge-upload path and parse them as text with the existing MarkItDown engine. The Go upload whitelist previously rejected
.sqlbefore DocReader was reached; DocReader also lacked the SQL routing entry.builtinengine requests for SQL through MarkItDown and allow explicit MarkItDown requests.SQL statements are read as document text, not executed.
Type of Change
Related Issue
Fixes #3494
Testing
.sqland.SQLuploads intoDocumentProcesswithout a spreadsheet-summary task.git diff --checkpassed.vue-tsc --buildand a deployed HTTP/gRPC/database end-to-end environment were not run locally.Checklist
This PR was prepared with AI assistance. Screenshots are not applicable to this file-admission and parser-routing change.