Repository navigation
Conversation
u7-u7
marked this pull request as ready for review
November 3, 2026 13:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scroll-to and targeted wheel check cancellation/deadline before/after target/geometry awaits. If a CDP reply such as DOM.resolveNode never arrives, the second check is unreachable: the tool remains pending after timeout_ms or signal abort. Awaiting object-group cleanup can also hold a completed result.
Change
Scope: target/geometry and object cleanup only. Does not cancel commands already delivered to Chrome, change wheel input-ack/overlay lifecycle, or claim every external phase is bounded. Cleanup remains best-effort if transport never responds.
Validation
Base6c9d523755b5607b4038b619e35b4e1f814d7838 with new tests:8 failed/88 passed. Fixed:
Real handlers with controlled CDP promises in repository happy-dom tests. Not run:live Chrome/browser evaluation,Rust workspace tests,full monorepo lint. Skipped tests are not counted as passes. Dependency install populated tools but wrapper reported unapproved @parcel/watcher build script; script not approved, installed test/typecheck binaries invoked directly.
All-state PR dedupe checked:input-readiness/wheel-burst changes #261/#480 do not cover pending geometry replies; process-group #511 unrelated.
AI-assisted implementation and automated tests/review. Draft for maintainers; no human-review claim.