Repository navigation
feat(daemon): support BSK_SESSION_IDLE and BSK_DAEMON_IDLE environment variables - #463
Open
legend91019 wants to merge 1 commit into
Open
legend91019 wants to merge 1 commit into
legend91019 wants to merge 1 commit into
Conversation
…t variables Make browser session idle timeout and daemon idle timeout configurable via environment variables BSK_SESSION_IDLE and BSK_DAEMON_IDLE. - Update StartArgs::resolved_session_idle() and resolved_daemon_idle() to fall back to environment variables. - Update ensure_daemon() to pass BSK_SESSION_IDLE and BSK_DAEMON_IDLE to auto-spawned background instances. - Update run_start() to resolve environment variables into StartArgs. - Add test coverage in crates/bsk-cli/tests/cli_parse.rs. - Document environment variables in crates/bsk-cli/skill/references/environment.md. Fixes Tencent#456
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #456.
Make session and daemon idle timeouts configurable through
BSK_SESSION_IDLEandBSK_DAEMON_IDLE, including automatic daemon startup.Previously,
--session-idleand--daemon-idlewere available only on explicitbsk daemon start/restartcommands. Automatically spawned daemons used the defaults of five minutes for sessions and ten minutes for the daemon.Changes
ensure_daemon()when starting a background daemon.crates/bsk-cli/skill/references/environment.md.The implementation touches
crates/bsk-cli/src/cli/daemon.rs,crates/bsk-cli/src/cli/ensure_daemon.rs,crates/bsk-cli/src/daemon/start.rs, andcrates/bsk-cli/tests/cli_parse.rs, in addition to the documentation.Validation
Implementation verification previously recorded for this branch:
cargo fmt --check: passed.cargo test -p bsk --test cli_parse --locked: 46 tests passed.cargo test -p bsk daemon::sessions --locked: passed.This description-only update repairs Markdown escaping and corrupted identifiers. It does not change the branch or claim a new test run. The currently visible external scan is separate from the locally recorded Rust checks.