Use CompletableFutures for async update checking - #1
Merged
Conversation
Contributor
Author
|
Oh, i also removed the |
TechnicJelle
self-requested a review
October 22, 2023 20:21
Owner
|
Do you think the readme also needs to be updated with mentions of these new additions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the necessity of calling
check()manually before logging the update-messages.It also moves the async logic to a
CompletableFutureto make sure that the actual check-call is only done once even if we callgetLatestVersion()multiple times in quick succession. :)