Extract pipeline run creation logic into reusable method#149
Open
Mbeaulne wants to merge 1 commit into03-11-adds_bulk_pipeline_submissionfrom
Open
Extract pipeline run creation logic into reusable method#149Mbeaulne wants to merge 1 commit into03-11-adds_bulk_pipeline_submissionfrom
Mbeaulne wants to merge 1 commit into03-11-adds_bulk_pipeline_submissionfrom
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Mbeaulne
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Extracted pipeline run creation logic into a reusable private method to eliminate code duplication between single and batch creation operations.
What changed?
Created a new
_build_pipeline_runmethod that encapsulates the pipeline run creation process, including building the execution tree, creating the PipelineRun record, flushing to obtain the server-generated ID, and mirroring system annotations. Both thecreateandcreate_batchmethods now call this shared method instead of duplicating the same logic.How to test?
Test both single pipeline run creation via the
createmethod and batch pipeline run creation via thecreate_batchmethod to ensure they continue to work as expected. Verify that pipeline runs are created with proper execution trees, annotations, and system metadata in both scenarios.Why make this change?
This refactoring eliminates code duplication between the single and batch creation methods, making the codebase more maintainable. Any future changes to the pipeline run creation logic only need to be made in one place, reducing the risk of inconsistencies and bugs.