chore: fix devtools dependeicies by ha1fstack · Pull Request #5819 · TanStack/router

ha1fstack · 2025-11-11T08:39:37Z

This PR fixes wrong dependency config of devtools related packages:

router-devtools-core > tiny-invariant should be a normal dependency

react-router-devtools and solid-router-devtools do not provide router-devtools-core 's peer dependency router-core so added it as optional peerDeps

Summary by CodeRabbit

Chores
- Enhanced dependency configuration across multiple devtools packages to improve overall compatibility and streamline the package installation process.
- Refined and optimized internal dependencies for better module resolution and reduced potential installation conflicts between packages.
- Updated peer dependency settings to ensure proper compatibility across different router framework integrations and use cases.

coderabbitai · 2025-11-11T08:39:51Z

Walkthrough

Updates dependency declarations across three dev-tools packages: adds optional peer dependencies on @tanstack/router-core to react-router-devtools and solid-router-devtools packages, and promotes tiny-invariant from peer dependency to direct runtime dependency in router-devtools-core.

Changes

Cohort / File(s)	Summary
Optional `@tanstack/router-core` peer dependency `packages/react-router-devtools/package.json`, `packages/solid-router-devtools/package.json`	Adds `@tanstack/router-core` as optional peer dependency with corresponding `peerDependenciesMeta` marking
tiny-invariant dependency promotion `packages/router-devtools-core/package.json`	Moves `tiny-invariant` from `peerDependencies` to `dependencies`

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Verify the @tanstack/router-core workspace version specifier is correct and consistent across packages
Confirm that promoting tiny-invariant to a runtime dependency in router-devtools-core doesn't create unintended version conflicts with dependents
Check that optional peer dependency metadata is properly formatted in both react-router-devtools and solid-router-devtools

Suggested reviewers

birkskyum
lachlancollins
SeanCassiere

Poem

🐰 Dependencies aligned with care,
Optional routers floating there,
Invariants pinned where they belong,
Each workspace version stays strong! 🌟

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title references fixing devtools dependencies, which aligns with the core objective of correcting dependency configuration across devtools packages.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5404201 and 78e6279.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (3)

packages/react-router-devtools/package.json (1 hunks)
packages/router-devtools-core/package.json (2 hunks)
packages/solid-router-devtools/package.json (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/package.json

📄 CodeRabbit inference engine (AGENTS.md)

Use workspace:* protocol for internal dependencies in package.json files

Files:

packages/react-router-devtools/package.json
packages/solid-router-devtools/package.json
packages/router-devtools-core/package.json

packages/{router-devtools,*-router-devtools}/**

📄 CodeRabbit inference engine (AGENTS.md)

Keep router devtools packages in packages/router-devtools/ and packages/*-router-devtools/

Files:

packages/react-router-devtools/package.json
packages/solid-router-devtools/package.json

🧠 Learnings (9)

📓 Common learnings

Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-09-23T17:36:12.598Z
Learning: Applies to packages/{router-devtools,*-router-devtools}/** : Keep router devtools packages in packages/router-devtools/ and packages/*-router-devtools/

Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-09-23T17:36:12.598Z
Learning: Applies to packages/{router-cli,router-generator,router-plugin,virtual-file-routes}/** : Keep CLI, generators, bundler plugins, and virtual file routing utilities in their dedicated tooling package directories

Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-09-23T17:36:12.598Z
Learning: Applies to packages/{react-router,solid-router}/** : Implement React and Solid bindings/components only in packages/react-router/ and packages/solid-router/

Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-09-23T17:36:12.598Z
Learning: Applies to packages/router-core/** : Keep framework-agnostic core router logic in packages/router-core/

Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-09-23T17:36:12.598Z
Learning: Applies to packages/router-plugin/** : Use unplugin for universal bundler plugins in the router-plugin package